From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Alex Gonzalez <alex.gonzalez@digi.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type
Date: Fri, 17 Apr 2020 16:10:58 +0300 [thread overview]
Message-ID: <20200417131058.GC4748@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1163e6e1-254d-07c9-496b-7bf2d3157a51@ti.com>
Hi Tomi,
Thank you for the patch.
On Fri, Apr 17, 2020 at 04:00:34PM +0300, Tomi Valkeinen wrote:
> (Adding Alex to the thread)
>
> On 17/04/2020 14:40, Tomi Valkeinen wrote:
> > The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> > indicated by the current bus_format.
> >
> > Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> > connector_type to LVDS.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
I'll trust you on the format,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..bf781e260fe7 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
> > .width = 216,
> > .height = 135,
> > },
> > - .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> > + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > };
> >
> > static const struct drm_display_mode auo_g104sn02_mode = {
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-17 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 11:40 [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type Tomi Valkeinen
2020-04-17 13:00 ` Tomi Valkeinen
2020-04-17 13:10 ` Laurent Pinchart [this message]
2020-05-04 19:46 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417131058.GC4748@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alex.gonzalez@digi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox