drm/panel: remove return value of function drm_panel_add which always return true.

drm/panel: remove return value of function drm_panel_add which always return true.

[Bernard]

Hi:

The function "int drm_panel_add(struct drm_panel *panel)" always returns true, this return value is meaningless.
So I am planning to optimize this function to a non-return implementation, "void drm_panel_add(struct drm_panel *panel)".

In order to achieve this optimization, I need to submit a patch series: 
First, modify the code of each submodule that depends on the return value of this function;
And last, replace the declaration in the drm_panel.h file and implementation in the drm_panel.c file;

Do you mind this optimization?
Looking forward to your reply and suggestions!

BR//Bernard





_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm/panel: remove return value of function drm_panel_add which always return true.

[Sam Ravnborg]

Hi Bernard,
On Tue, Jul 21, 2020 at 08:24:05PM +0800, Bernard wrote:
> 
> Hi:
> 
> The function "int drm_panel_add(struct drm_panel *panel)" always returns true, this return value is meaningless.
> So I am planning to optimize this function to a non-return implementation, "void drm_panel_add(struct drm_panel *panel)".
> 
> In order to achieve this optimization, I need to submit a patch series: 
> First, modify the code of each submodule that depends on the return value of this function;
> And last, replace the declaration in the drm_panel.h file and implementation in the drm_panel.c file;
> 
> Do you mind this optimization?
> Looking forward to your reply and suggestions!

First of all, thanks for reaching out.

And yes, please implement this simplification.

To avoid this ends up in too much small patches then I advise you to
divide it up like this:

- One patch to convert all panel drivers in drm/panel/*
  Or if you think this is too much to handle in one patch then split
  it in a few patches.
  We do not want one patch for each panel driver.
- Then a final patch to remove the return value from drm/drm_panel.c

Patches should be made on top of drm-misc-next.

This will make the number of patches manageable, easier to give good
names and easiest to review.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel