* [PATCH 1/3] dt-bindings: Add vendor prefix for Powertip
@ 2020-07-25 21:13 Marek Vasut
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
2020-07-25 21:13 ` [PATCH 3/3] drm/panel: simple: " Marek Vasut
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2020-07-25 21:13 UTC (permalink / raw)
To: dri-devel; +Cc: Marek Vasut, Rob Herring, Sam Ravnborg, devicetree
The Powertip Tech. Corp. is an LCD panel manufacturer.
Signed-off-by: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 30d2232ccc0f..0f8894e54878 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -826,6 +826,8 @@ patternProperties:
description: Poslab Technology Co., Ltd.
"^pov,.*":
description: Point of View International B.V.
+ "^powertip,.*":
+ description: Powertip Tech. Corp.
"^powervr,.*":
description: PowerVR (deprecated, use img)
"^primux,.*":
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013
2020-07-25 21:13 [PATCH 1/3] dt-bindings: Add vendor prefix for Powertip Marek Vasut
@ 2020-07-25 21:13 ` Marek Vasut
2020-07-26 6:55 ` Sam Ravnborg
2020-07-27 18:10 ` Rob Herring
2020-07-25 21:13 ` [PATCH 3/3] drm/panel: simple: " Marek Vasut
1 sibling, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2020-07-25 21:13 UTC (permalink / raw)
To: dri-devel; +Cc: Marek Vasut, Rob Herring, Sam Ravnborg, devicetree
Add DT bindings for Powertip PH800480T013 800x480 parallel LCD,
this one is used in the Raspberry Pi 7" touchscreen display unit.
Signed-off-by: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
---
.../panel/powertip,ph800480t013-idf02.yaml | 28 +++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
new file mode 100644
index 000000000000..8a2a4f79f365
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: POWERTIP PH800480T013-IDF2 7.0" WVGA TFT LCD panel
+
+maintainers:
+ - Marek Vasut <marex@denx.de>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: powertip,ph800480t013-idf02
+
+ power-supply: true
+ backlight: true
+ port: true
+
+additionalProperties: false
+
+required:
+ - compatible
+
+...
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] drm/panel: simple: Add DT bindings for Powertip PH800480T013
2020-07-25 21:13 [PATCH 1/3] dt-bindings: Add vendor prefix for Powertip Marek Vasut
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
@ 2020-07-25 21:13 ` Marek Vasut
2020-07-26 6:57 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2020-07-25 21:13 UTC (permalink / raw)
To: dri-devel; +Cc: Marek Vasut, Rob Herring, Sam Ravnborg, devicetree
Add support for Powertip PH800480T013 800x480 parallel LCD, this
one is used in the Raspberry Pi 7" touchscreen display unit.
Signed-off-by: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
---
drivers/gpu/drm/panel/panel-simple.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index af6ea5480c81..6bf6604ca78e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2986,6 +2986,27 @@ static const struct panel_desc pda_91_00156_a0 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
+ .clock = 24750,
+ .hdisplay = 800,
+ .hsync_start = 800 + 54,
+ .hsync_end = 800 + 54 + 2,
+ .htotal = 800 + 54 + 2 + 44,
+ .vdisplay = 480,
+ .vsync_start = 480 + 49,
+ .vsync_end = 480 + 49 + 2,
+ .vtotal = 480 + 49 + 2 + 22,
+};
+
+static const struct panel_desc powertip_ph800480t013_idf02 = {
+ .modes = &powertip_ph800480t013_idf02_mode,
+ .num_modes = 1,
+ .size = {
+ .width = 152,
+ .height = 91,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
static const struct drm_display_mode qd43003c0_40_mode = {
.clock = 9000,
@@ -3998,6 +4019,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "pda,91-00156-a0",
.data = &pda_91_00156_a0,
+ }, {
+ .compatible = "powertip,ph800480t013-idf02",
+ .data = &powertip_ph800480t013_idf02,
}, {
.compatible = "qiaodian,qd43003c0-40",
.data = &qd43003c0_40,
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
@ 2020-07-26 6:55 ` Sam Ravnborg
2020-07-27 18:10 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2020-07-26 6:55 UTC (permalink / raw)
To: Marek Vasut; +Cc: Rob Herring, dri-devel, devicetree
Hi Marek.
On Sat, Jul 25, 2020 at 11:13:34PM +0200, Marek Vasut wrote:
> Add DT bindings for Powertip PH800480T013 800x480 parallel LCD,
> this one is used in the Raspberry Pi 7" touchscreen display unit.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> To: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../panel/powertip,ph800480t013-idf02.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> new file mode 100644
> index 000000000000..8a2a4f79f365
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: POWERTIP PH800480T013-IDF2 7.0" WVGA TFT LCD panel
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: powertip,ph800480t013-idf02
> +
> + power-supply: true
> + backlight: true
> + port: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +...
The binding matches what we have in panel-simple.yaml.
So it should be added there, and not an independent binding file.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] drm/panel: simple: Add DT bindings for Powertip PH800480T013
2020-07-25 21:13 ` [PATCH 3/3] drm/panel: simple: " Marek Vasut
@ 2020-07-26 6:57 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2020-07-26 6:57 UTC (permalink / raw)
To: Marek Vasut; +Cc: Rob Herring, dri-devel, devicetree
Hi Marex
On Sat, Jul 25, 2020 at 11:13:35PM +0200, Marek Vasut wrote:
> Add support for Powertip PH800480T013 800x480 parallel LCD, this
> one is used in the Raspberry Pi 7" touchscreen display unit.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> To: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> ---
> drivers/gpu/drm/panel/panel-simple.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index af6ea5480c81..6bf6604ca78e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2986,6 +2986,27 @@ static const struct panel_desc pda_91_00156_a0 = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
> + .clock = 24750,
> + .hdisplay = 800,
> + .hsync_start = 800 + 54,
> + .hsync_end = 800 + 54 + 2,
> + .htotal = 800 + 54 + 2 + 44,
> + .vdisplay = 480,
> + .vsync_start = 480 + 49,
> + .vsync_end = 480 + 49 + 2,
> + .vtotal = 480 + 49 + 2 + 22,
> +};
> +
> +static const struct panel_desc powertip_ph800480t013_idf02 = {
> + .modes = &powertip_ph800480t013_idf02_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};
For new panels we today requires:
- connector_type
- bus_flags
- bus_format
(Assuming this is a DPI connector panel).
We are working on a patch that wll warn for panels missing required
info. Today a lot of panels are missing info so it is easy to find
panels that does not include all relevant info.
Sam
>
> static const struct drm_display_mode qd43003c0_40_mode = {
> .clock = 9000,
> @@ -3998,6 +4019,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "pda,91-00156-a0",
> .data = &pda_91_00156_a0,
> + }, {
> + .compatible = "powertip,ph800480t013-idf02",
> + .data = &powertip_ph800480t013_idf02,
> }, {
> .compatible = "qiaodian,qd43003c0-40",
> .data = &qd43003c0_40,
> --
> 2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
2020-07-26 6:55 ` Sam Ravnborg
@ 2020-07-27 18:10 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-07-27 18:10 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, Rob Herring, Sam Ravnborg, dri-devel
On Sat, 25 Jul 2020 23:13:34 +0200, Marek Vasut wrote:
> Add DT bindings for Powertip PH800480T013 800x480 parallel LCD,
> this one is used in the Raspberry Pi 7" touchscreen display unit.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> To: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../panel/powertip,ph800480t013-idf02.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml: $id: 'http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02.yaml#
Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml: ignoring, error in schema: $id
warning: no schema found in file: ./Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml: ignoring, error in schema: $id
warning: no schema found in file: ./Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1336335
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-27 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-25 21:13 [PATCH 1/3] dt-bindings: Add vendor prefix for Powertip Marek Vasut
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
2020-07-26 6:55 ` Sam Ravnborg
2020-07-27 18:10 ` Rob Herring
2020-07-25 21:13 ` [PATCH 3/3] drm/panel: simple: " Marek Vasut
2020-07-26 6:57 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox