[radeon-alex:amd-staging-drm-next 443/482] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:39:6: sparse: sparse: symbol 'kfd_initialized' was not declared. Should it be

[radeon-alex:amd-staging-drm-next 443/482] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:39:6: sparse: sparse: symbol 'kfd_initialized' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   6fe4a372821db85834f5522d94d25139ff17e414
commit: 0b54e1e30e9f201a63922344917e11ab60da0d1b [443/482] drm/amdgpu: Fix handling of KFD initialization failures
config: x86_64-randconfig-s021-20200920 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-201-g24bdaac6-dirty
        git checkout 0b54e1e30e9f201a63922344917e11ab60da0d1b
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:39:6: sparse: sparse: symbol 'kfd_initialized' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39734 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC PATCH radeon-alex] drm/amdgpu: kfd_initialized can be static

[kernel test robot]

Fixes: 0b54e1e30e9f ("drm/amdgpu: Fix handling of KFD initialization failures")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 amdgpu_amdkfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 7f14461f7f402..01780bb8727f6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -36,7 +36,7 @@
  */
 uint64_t amdgpu_amdkfd_total_mem_size;
 
-bool kfd_initialized;
+static bool kfd_initialized;
 
 int amdgpu_amdkfd_init(void)
 {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH radeon-alex] drm/amdgpu: kfd_initialized can be static

[Felix Kuehling]

FYI, I applied this patch to amd-staging-drm-next. Sorry for the delay,
I finally caught up with my vacation backlog.

Regards,
  Felix

Am 2020-09-22 um 10:28 p.m. schrieb kernel test robot:
> Fixes: 0b54e1e30e9f ("drm/amdgpu: Fix handling of KFD initialization failures")
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  amdgpu_amdkfd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 7f14461f7f402..01780bb8727f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -36,7 +36,7 @@
>   */
>  uint64_t amdgpu_amdkfd_total_mem_size;
>  
> -bool kfd_initialized;
> +static bool kfd_initialized;
>  
>  int amdgpu_amdkfd_init(void)
>  {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel