From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: amd-gfx@lists.freedesktop.org, "Dom Cobley" <dom@raspberrypi.com>,
"Tim Gover" <tim.gover@raspberrypi.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Phil Elwell" <phil@raspberrypi.com>
Subject: [PATCH v2 05/22] drm/amd/display: Fix color encoding mismatch
Date: Mon, 21 Feb 2022 10:59:01 +0100 [thread overview]
Message-ID: <20220221095918.18763-6-maxime@cerno.tech> (raw)
In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech>
The amdgpu KMS driver calls drm_plane_create_color_properties() with a
default encoding set to BT709.
However, the core will ignore it and the driver doesn't force it in its
plane state reset hook, so the initial value will be 0, which represents
BT601.
Fix the mismatch by using an initial value of BT601 in
drm_plane_create_color_properties().
Cc: amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index feccf2b555d2..86b27a355e90 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7914,7 +7914,7 @@ static int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
BIT(DRM_COLOR_YCBCR_BT2020),
BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
BIT(DRM_COLOR_YCBCR_FULL_RANGE),
- DRM_COLOR_YCBCR_BT709, DRM_COLOR_YCBCR_LIMITED_RANGE);
+ DRM_COLOR_YCBCR_BT601, DRM_COLOR_YCBCR_LIMITED_RANGE);
}
supported_rotations =
--
2.35.1
next prev parent reply other threads:[~2022-02-21 9:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:58 [PATCH v2 00/22] drm: Fill in default values for plane properties Maxime Ripard
2022-02-21 9:58 ` [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper Maxime Ripard
2022-02-25 13:59 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:58 ` [PATCH v2 02/22] drm/tegra: " Maxime Ripard
2022-02-21 9:58 ` [PATCH v2 03/22] drm/tegra: hub: Fix zpos initial value mismatch Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 04/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` Maxime Ripard [this message]
2022-02-21 9:59 ` [PATCH v2 06/22] drm/object: Add drm_object_property_get_default_value() function Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 07/22] drm/object: Add default zpos value at reset Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 08/22] drm/tegra: plane: Remove redundant zpos initialisation Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 09/22] drm/komeda: " Maxime Ripard
2022-02-25 13:59 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 10/22] drm/exynos: " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 11/22] drm/imx: ipuv3-plane: " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 12/22] drm/msm/mdp5: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 13/22] drm/nouveau/kms: " Maxime Ripard
2022-02-21 16:42 ` Karol Herbst
2022-02-22 14:02 ` Maxime Ripard
2022-02-22 21:35 ` Karol Herbst
2022-02-22 20:36 ` Lyude Paul
2022-02-25 17:14 ` (subset) [Nouveau] " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 14/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 15/22] drm/rcar: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 16/22] drm/sti: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 17/22] drm/sun4i: layer: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 18/22] drm/object: Add default color encoding and range value at reset Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 19/22] drm/komeda: plane: Remove redundant color encoding and range initialisation Maxime Ripard
2022-02-25 14:01 ` Liviu Dudau
2022-03-08 11:04 ` (subset) " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 20/22] drm/armada: overlay: " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 21/22] drm/imx: ipuv3-plane: " Maxime Ripard
2022-02-21 9:59 ` [PATCH v2 22/22] drm/omap: plane: " Maxime Ripard
2022-02-25 17:14 ` (subset) " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221095918.18763-6-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=phil@raspberrypi.com \
--cc=sunpeng.li@amd.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox