From: Sam Ravnborg <sam@ravnborg.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: neil.armstrong@linaro.org, Fabio Estevam <festevam@denx.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24
Date: Wed, 21 Jun 2023 19:40:48 +0200 [thread overview]
Message-ID: <20230621174048.GA2301301@ravnborg.org> (raw)
In-Reply-To: <20230620112202.654981-1-festevam@gmail.com>
On Tue, Jun 20, 2023 at 08:22:02AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
> information to avoid the following warning:
>
> panel-simple panel: Specify missing connector_type
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")
Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I expect someone else to pick it up.
Sam
> ---
> Changes since v1:
> - Pass Fixes tag (Neil).
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index a247a0e7c799..7c80528d571e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
> .height = 54,
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> };
>
> --
> 2.34.1
next prev parent reply other threads:[~2023-06-21 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 11:22 [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24 Fabio Estevam
2023-06-21 17:40 ` Sam Ravnborg [this message]
2023-06-22 8:04 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621174048.GA2301301@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox