* [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24
@ 2023-06-20 11:22 Fabio Estevam
2023-06-21 17:40 ` Sam Ravnborg
2023-06-22 8:04 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-06-20 11:22 UTC (permalink / raw)
To: neil.armstrong; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <festevam@denx.de>
The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
information to avoid the following warning:
panel-simple panel: Specify missing connector_type
Signed-off-by: Fabio Estevam <festevam@denx.de>
Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")
---
Changes since v1:
- Pass Fixes tag (Neil).
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index a247a0e7c799..7c80528d571e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
.height = 54,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24
2023-06-20 11:22 [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24 Fabio Estevam
@ 2023-06-21 17:40 ` Sam Ravnborg
2023-06-22 8:04 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2023-06-21 17:40 UTC (permalink / raw)
To: Fabio Estevam; +Cc: neil.armstrong, Fabio Estevam, dri-devel
On Tue, Jun 20, 2023 at 08:22:02AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
> information to avoid the following warning:
>
> panel-simple panel: Specify missing connector_type
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")
Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I expect someone else to pick it up.
Sam
> ---
> Changes since v1:
> - Pass Fixes tag (Neil).
>
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index a247a0e7c799..7c80528d571e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2178,6 +2178,7 @@ static const struct panel_desc innolux_at043tn24 = {
> .height = 54,
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> };
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24
2023-06-20 11:22 [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24 Fabio Estevam
2023-06-21 17:40 ` Sam Ravnborg
@ 2023-06-22 8:04 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-06-22 8:04 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, dri-devel
Hi,
On Tue, 20 Jun 2023 08:22:02 -0300, Fabio Estevam wrote:
> The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type'
> information to avoid the following warning:
>
> panel-simple panel: Specify missing connector_type
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/panel: simple: Add connector_type for innolux_at043tn24
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=2c56a751845ddfd3078ebe79981aaaa182629163
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-22 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 11:22 [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24 Fabio Estevam
2023-06-21 17:40 ` Sam Ravnborg
2023-06-22 8:04 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).