[PATCH] drm/panel: simple: Drop prepared_time

[PATCH] drm/panel: simple: Drop prepared_time

[Marek Vasut]

This has been superseded by RPM in commit
3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
and the last user of the non-RPM case has been dropped in commit
b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling")
whatever is left in this driver is just assigned and never used.
Drop the remaining parts.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/panel/panel-simple.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 37afed67fea7e..e943148dd2b0c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -141,7 +141,6 @@ struct panel_simple {
 
 	bool prepared;
 
-	ktime_t prepared_time;
 	ktime_t unprepared_time;
 
 	const struct panel_desc *desc;
@@ -351,8 +350,6 @@ static int panel_simple_resume(struct device *dev)
 	if (p->desc->delay.prepare)
 		msleep(p->desc->delay.prepare);
 
-	p->prepared_time = ktime_get_boottime();
-
 	return 0;
 }
 
@@ -566,7 +563,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 		return -ENOMEM;
 
 	panel->enabled = false;
-	panel->prepared_time = 0;
 	panel->unprepared_time = ktime_get_boottime();
 	panel->desc = desc;
 
-- 
2.40.1

Re: [PATCH] drm/panel: simple: Drop prepared_time

[Sam Ravnborg]

On Sun, Jul 09, 2023 at 06:22:53PM +0200, Marek Vasut wrote:
> This has been superseded by RPM in commit
> 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
> and the last user of the non-RPM case has been dropped in commit
> b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling")
> whatever is left in this driver is just assigned and never used.
> Drop the remaining parts.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: dri-devel@lists.freedesktop.org

Thanks,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Re: [PATCH] drm/panel: simple: Drop prepared_time

[Doug Anderson]

Hi,

On Sun, Jul 9, 2023 at 9:23 AM Marek Vasut <marex@denx.de> wrote:
>
> This has been superseded by RPM in commit
> 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
> and the last user of the non-RPM case has been dropped in commit
> b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling")
> whatever is left in this driver is just assigned and never used.
> Drop the remaining parts.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 4 ----
>  1 file changed, 4 deletions(-)

Thanks for cleaning this up.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I'm happy to apply this or happy for others to. I'll wait a few more
days and then apply it if nobody else has.

-Doug

Re: [PATCH] drm/panel: simple: Drop prepared_time

[Doug Anderson]

Hi,

On Tue, Jul 18, 2023 at 7:23 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Sun, Jul 9, 2023 at 9:23 AM Marek Vasut <marex@denx.de> wrote:
> >
> > This has been superseded by RPM in commit
> > 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
> > and the last user of the non-RPM case has been dropped in commit
> > b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling")
> > whatever is left in this driver is just assigned and never used.
> > Drop the remaining parts.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > ---
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Cc: Neil Armstrong <neil.armstrong@linaro.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 4 ----
> >  1 file changed, 4 deletions(-)
>
> Thanks for cleaning this up.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> I'm happy to apply this or happy for others to. I'll wait a few more
> days and then apply it if nobody else has.

As promised, I've pushed this to drm-misc-next.

c942e935ff3f drm/panel: simple: Drop prepared_time

I had to manually resolve the context conflict since this patch only
applied cleanly atop your other patch [1]. However, the resolution was
trivial.

[1] https://lore.kernel.org/all/20230709135231.449636-1-marex@denx.de/