dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
To: dri-devel@lists.freedesktop.org
Cc: andrealmeid@igalia.com, tzimmermann@suse.de,
	tales.aparecida@gmail.com, mripard@kernel.org,
	mairacanal@riseup.net,
	Carlos Eduardo Gallo Filho <gcarlos@disroot.org>,
	davidgow@google.com, michal.winiarski@intel.com,
	arthurgrillo@riseup.net
Subject: [PATCH v2 1/4] drm: Add kernel-doc for drm_framebuffer_check_src_coords()
Date: Tue, 18 Jul 2023 15:17:23 -0300	[thread overview]
Message-ID: <20230718181726.3799-2-gcarlos@disroot.org> (raw)
In-Reply-To: <20230718181726.3799-1-gcarlos@disroot.org>

Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
---
 drivers/gpu/drm/drm_framebuffer.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
index aff3746dedfb..49df3ca3b3ee 100644
--- a/drivers/gpu/drm/drm_framebuffer.c
+++ b/drivers/gpu/drm/drm_framebuffer.c
@@ -73,6 +73,21 @@
  * drm_framebuffer.
  */
 
+/**
+ * drm_framebuffer_check_src_coords - check if the source with given
+ * coordinates and sizes is inside the framebuffer
+ * @src_x: source x coordinate
+ * @src_y: source y coordinate
+ * @src_w: source width
+ * @src_h: source height
+ * @fb: pointer to the framebuffer to check
+ *
+ * This function checks if an object with the given set of coordinates and
+ * sizes fits inside the framebuffer by looking at its size.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
 int drm_framebuffer_check_src_coords(uint32_t src_x, uint32_t src_y,
 				     uint32_t src_w, uint32_t src_h,
 				     const struct drm_framebuffer *fb)
@@ -82,7 +97,6 @@ int drm_framebuffer_check_src_coords(uint32_t src_x, uint32_t src_y,
 	fb_width = fb->width << 16;
 	fb_height = fb->height << 16;
 
-	/* Make sure source coordinates are inside the fb. */
 	if (src_w > fb_width ||
 	    src_x > fb_width - src_w ||
 	    src_h > fb_height ||
-- 
2.41.0


  reply	other threads:[~2023-07-18 18:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 18:17 [PATCH v2 0/4] Add documentation and KUnit tests for functions on drm_framebuffer.c Carlos Eduardo Gallo Filho
2023-07-18 18:17 ` Carlos Eduardo Gallo Filho [this message]
2023-07-19  7:24   ` [PATCH v2 1/4] drm: Add kernel-doc for drm_framebuffer_check_src_coords() Maxime Ripard
2023-07-18 18:17 ` [PATCH v2 2/4] drm/tests: Add test " Carlos Eduardo Gallo Filho
2023-07-19  6:50   ` kernel test robot
2023-07-19  7:36     ` Maxime Ripard
2023-07-19  7:49   ` Maxime Ripard
2023-07-19 16:24     ` Carlos
2023-07-19 14:33   ` kernel test robot
2023-07-18 18:17 ` [PATCH v2 3/4] drm/tests: Add parameters to the drm_test_framebuffer_create test Carlos Eduardo Gallo Filho
2023-07-18 18:17 ` [PATCH v2 4/4] drm/tests: Add test case for drm_internal_framebuffer_create() Carlos Eduardo Gallo Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718181726.3799-2-gcarlos@disroot.org \
    --to=gcarlos@disroot.org \
    --cc=andrealmeid@igalia.com \
    --cc=arthurgrillo@riseup.net \
    --cc=davidgow@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mairacanal@riseup.net \
    --cc=michal.winiarski@intel.com \
    --cc=mripard@kernel.org \
    --cc=tales.aparecida@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox