From: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
To: dri-devel@lists.freedesktop.org
Cc: andrealmeid@igalia.com, tzimmermann@suse.de,
tales.aparecida@gmail.com, mripard@kernel.org,
mairacanal@riseup.net,
Carlos Eduardo Gallo Filho <gcarlos@disroot.org>,
davidgow@google.com, michal.winiarski@intel.com,
arthurgrillo@riseup.net
Subject: [PATCH v2 3/4] drm/tests: Add parameters to the drm_test_framebuffer_create test
Date: Tue, 18 Jul 2023 15:17:25 -0300 [thread overview]
Message-ID: <20230718181726.3799-4-gcarlos@disroot.org> (raw)
In-Reply-To: <20230718181726.3799-1-gcarlos@disroot.org>
Extend the existing test case to cover:
1. Invalid flag atribute in the struct drm_mode_fb_cmd2.
2. Pixel format which requires non-linear modifier with
DRM_FORMAT_MOD_LINEAR set.
3. Non-zero buffer offset for an unused plane
Also replace strcpy to strscpy on test_to_desc for improved security
and reliability.
Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
---
drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
index ee92120cd8e9..cbab12503f5f 100644
--- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
+++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
@@ -20,6 +20,8 @@
#define MIN_HEIGHT 4
#define MAX_HEIGHT 4096
+#define DRM_MODE_FB_INVALID BIT(2)
+
struct drm_framebuffer_test {
int buffer_created;
struct drm_mode_fb_cmd2 cmd;
@@ -84,6 +86,18 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
.pitches = { 4 * MAX_WIDTH, 0, 0 },
}
},
+{ .buffer_created = 0, .name = "ABGR8888 Non-zero buffer offset for unused plane",
+ .cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
+ .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, UINT_MAX / 2, 0 },
+ .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
+ }
+},
+{ .buffer_created = 0, .name = "ABGR8888 Invalid flag",
+ .cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
+ .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
+ .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_INVALID,
+ }
+},
{ .buffer_created = 1, .name = "ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers",
.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
.handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
@@ -263,6 +277,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
.pitches = { MAX_WIDTH, DIV_ROUND_UP(MAX_WIDTH, 2), DIV_ROUND_UP(MAX_WIDTH, 2) },
}
},
+{ .buffer_created = 0, .name = "YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)",
+ .cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_YUV420_10BIT,
+ .handles = { 1, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
+ .modifier = { DRM_FORMAT_MOD_LINEAR, 0, 0 },
+ .pitches = { MAX_WIDTH, 0, 0 },
+ }
+},
{ .buffer_created = 1, .name = "X0L2 Normal sizes",
.cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_X0L2,
.handles = { 1, 0, 0 }, .pitches = { 1200, 0, 0 }
@@ -361,7 +382,7 @@ static void drm_test_framebuffer_create(struct kunit *test)
static void drm_framebuffer_test_to_desc(const struct drm_framebuffer_test *t, char *desc)
{
- strcpy(desc, t->name);
+ strscpy(desc, t->name, KUNIT_PARAM_DESC_SIZE);
}
KUNIT_ARRAY_PARAM(drm_framebuffer_create, drm_framebuffer_create_cases,
--
2.41.0
next prev parent reply other threads:[~2023-07-18 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 18:17 [PATCH v2 0/4] Add documentation and KUnit tests for functions on drm_framebuffer.c Carlos Eduardo Gallo Filho
2023-07-18 18:17 ` [PATCH v2 1/4] drm: Add kernel-doc for drm_framebuffer_check_src_coords() Carlos Eduardo Gallo Filho
2023-07-19 7:24 ` Maxime Ripard
2023-07-18 18:17 ` [PATCH v2 2/4] drm/tests: Add test " Carlos Eduardo Gallo Filho
2023-07-19 6:50 ` kernel test robot
2023-07-19 7:36 ` Maxime Ripard
2023-07-19 7:49 ` Maxime Ripard
2023-07-19 16:24 ` Carlos
2023-07-19 14:33 ` kernel test robot
2023-07-18 18:17 ` Carlos Eduardo Gallo Filho [this message]
2023-07-18 18:17 ` [PATCH v2 4/4] drm/tests: Add test case for drm_internal_framebuffer_create() Carlos Eduardo Gallo Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718181726.3799-4-gcarlos@disroot.org \
--to=gcarlos@disroot.org \
--cc=andrealmeid@igalia.com \
--cc=arthurgrillo@riseup.net \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mairacanal@riseup.net \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=tales.aparecida@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox