dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
To: dri-devel@lists.freedesktop.org
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Arthur Grillo" <arthurgrillo@riseup.net>,
	"Tales Lelo da Aparecida" <tales.aparecida@gmail.com>,
	"Carlos Eduardo Gallo Filho" <gcarlos@disroot.org>
Subject: [PATCH v3 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test
Date: Wed,  3 Jul 2024 14:22:21 -0300	[thread overview]
Message-ID: <20240703172228.11166-3-gcarlos@disroot.org> (raw)
In-Reply-To: <20240703172228.11166-1-gcarlos@disroot.org>

Extend the existing test case to cover:
1. Invalid flag atribute in the struct drm_mode_fb_cmd2.
2. Pixel format which requires non-linear modifier with
DRM_FORMAT_MOD_LINEAR set.
3. Buffer offset for inexistent plane

Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
---
v2:
  - Remove strcpy to strscpy change.
v3:
  - Rename and commment the "Buffer offset for inexistent plane"
    test case.
---
 drivers/gpu/drm/tests/drm_framebuffer_test.c | 27 ++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
index 3882a88b6631..3ed987423322 100644
--- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
+++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
@@ -21,6 +21,8 @@
 #define MIN_HEIGHT 4
 #define MAX_HEIGHT 4096
 
+#define DRM_MODE_FB_INVALID BIT(2)
+
 struct drm_framebuffer_test {
 	int buffer_created;
 	struct drm_mode_fb_cmd2 cmd;
@@ -85,6 +87,24 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
 		 .pitches = { 4 * MAX_WIDTH, 0, 0 },
 	}
 },
+
+/*
+ * All entries in members that represents per-plane values (@modifier, @handles,
+ * @pitches and @offsets) must be zero when unused.
+ */
+{ .buffer_created = 0, .name = "ABGR8888 Buffer offset for inexistent plane",
+	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
+		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, UINT_MAX / 2, 0 },
+		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
+	}
+},
+
+{ .buffer_created = 0, .name = "ABGR8888 Invalid flag",
+	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
+		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
+		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_INVALID,
+	}
+},
 { .buffer_created = 1, .name = "ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers",
 	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
 		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
@@ -264,6 +284,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
 		 .pitches = { MAX_WIDTH, DIV_ROUND_UP(MAX_WIDTH, 2), DIV_ROUND_UP(MAX_WIDTH, 2) },
 	}
 },
+{ .buffer_created = 0, .name = "YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)",
+	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_YUV420_10BIT,
+		 .handles = { 1, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
+		 .modifier = { DRM_FORMAT_MOD_LINEAR, 0, 0 },
+		 .pitches = { MAX_WIDTH, 0, 0 },
+	}
+},
 { .buffer_created = 1, .name = "X0L2 Normal sizes",
 	.cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_X0L2,
 		 .handles = { 1, 0, 0 }, .pitches = { 1200, 0, 0 }
-- 
2.44.2


  parent reply	other threads:[~2024-07-03 17:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 17:22 [PATCH v3 0/9] Increase coverage on drm_framebuffer.c Carlos Eduardo Gallo Filho
2024-07-03 17:22 ` [PATCH v3 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests Carlos Eduardo Gallo Filho
2024-07-08 11:24   ` Maxime Ripard
2024-07-03 17:22 ` Carlos Eduardo Gallo Filho [this message]
2024-07-08 11:25   ` [PATCH v3 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 3/9] drm/tests: Replace strcpy to strscpy on " Carlos Eduardo Gallo Filho
2024-07-08 11:25   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 4/9] drm/tests: Add test case for drm_internal_framebuffer_create() Carlos Eduardo Gallo Filho
2024-07-08 11:28   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords() Carlos Eduardo Gallo Filho
2024-07-08 11:28   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 6/9] drm/tests: Add test for drm_framebuffer_cleanup() Carlos Eduardo Gallo Filho
2024-07-08 11:29   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 7/9] drm/tests: Add test for drm_framebuffer_lookup() Carlos Eduardo Gallo Filho
2024-07-08 11:29   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 8/9] drm/tests: Add test for drm_framebuffer_init() Carlos Eduardo Gallo Filho
2024-07-05  5:37   ` kernel test robot
2024-07-08 11:35   ` Maxime Ripard
2024-07-03 17:22 ` [PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free() Carlos Eduardo Gallo Filho
2024-07-05 11:06   ` kernel test robot
2024-07-08 11:36   ` Maxime Ripard
2024-07-08 16:41     ` Carlos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703172228.11166-3-gcarlos@disroot.org \
    --to=gcarlos@disroot.org \
    --cc=airlied@gmail.com \
    --cc=andrealmeid@igalia.com \
    --cc=arthurgrillo@riseup.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mairacanal@riseup.net \
    --cc=mripard@kernel.org \
    --cc=tales.aparecida@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox