From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm: crtc-helper: Remove useless loop
Date: Wed, 28 May 2014 16:35:50 +0200 [thread overview]
Message-ID: <2024324.A0AEyACNkt@avalon> (raw)
In-Reply-To: <20140528133638.GV14841@phenom.ffwll.local>
Hi Daniel,
On Wednesday 28 May 2014 15:36:38 Daniel Vetter wrote:
> On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> > Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> > disable disconnected outputs") made the for each loop over connectors
> > empty in __drm_helper_disable_unused_functions(). Remove the loop
> > altogether.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Isn't the local variable connector now unused?
Yes it is. Missing hunk in my patch, sorry about that :-/
> At least that's what my old patch did:
>
> http://patchwork.freedesktop.org/patch/24184/
Looks like I've missed it. Sorry for the noise.
> /me looks at Dave ...
>
> Cheers, Daniel
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-05-28 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 12:43 [PATCH] drm: crtc-helper: Remove useless loop Laurent Pinchart
2014-05-28 13:36 ` Daniel Vetter
2014-05-28 14:35 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024324.A0AEyACNkt@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox