From: Daniel Vetter <daniel@ffwll.ch>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm: crtc-helper: Remove useless loop
Date: Wed, 28 May 2014 15:36:38 +0200 [thread overview]
Message-ID: <20140528133638.GV14841@phenom.ffwll.local> (raw)
In-Reply-To: <1401281016-4874-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> disable disconnected outputs") made the for each loop over connectors
> empty in __drm_helper_disable_unused_functions(). Remove the loop
> altogether.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Isn't the local variable connector now unused? At least that's what my old
patch did:
http://patchwork.freedesktop.org/patch/24184/
/me looks at Dave ...
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index df281b5..fbc3aa7 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -145,11 +145,6 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
>
> drm_warn_on_modeset_not_all_locked(dev);
>
> - list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
> - if (!connector->encoder)
> - continue;
> - }
> -
> list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
> if (!drm_helper_encoder_in_use(encoder)) {
> drm_encoder_disable(encoder);
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-28 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 12:43 [PATCH] drm: crtc-helper: Remove useless loop Laurent Pinchart
2014-05-28 13:36 ` Daniel Vetter [this message]
2014-05-28 14:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528133638.GV14841@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox