* [PATCH] drm/hyperv: include drm_print.h where needed
@ 2025-11-04 10:02 Jani Nikula
2025-11-04 10:27 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2025-11-04 10:02 UTC (permalink / raw)
To: dri-devel; +Cc: jani.nikula, Stephen Rothwell, Thomas Zimmermann
hyperv_drm_drv.c and hyperv_drm_modeset.c depend on drm_print.h being
indirectly included via drm_buddy.h, drm_mm.h, or
ttm/ttm_resource.h. Include drm_print.h explicitly.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20251104101158.1cc9abcd@canb.auug.org.au
Fixes: f6e8dc9edf96 ("drm: include drm_print.h where needed")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index 0d49f168a919..06b5d96e6eaf 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -14,6 +14,7 @@
#include <drm/drm_drv.h>
#include <drm/drm_fbdev_shmem.h>
#include <drm/drm_gem_shmem_helper.h>
+#include <drm/drm_print.h>
#include <drm/drm_simple_kms_helper.h>
#include "hyperv_drm.h"
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 6e6eb1c12a68..7978f8c8108c 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -19,6 +19,7 @@
#include <drm/drm_probe_helper.h>
#include <drm/drm_panic.h>
#include <drm/drm_plane.h>
+#include <drm/drm_print.h>
#include <drm/drm_vblank.h>
#include <drm/drm_vblank_helper.h>
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/hyperv: include drm_print.h where needed
2025-11-04 10:02 [PATCH] drm/hyperv: include drm_print.h where needed Jani Nikula
@ 2025-11-04 10:27 ` Thomas Zimmermann
2025-11-04 12:43 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2025-11-04 10:27 UTC (permalink / raw)
To: Jani Nikula, dri-devel; +Cc: Stephen Rothwell
Am 04.11.25 um 11:02 schrieb Jani Nikula:
> hyperv_drm_drv.c and hyperv_drm_modeset.c depend on drm_print.h being
> indirectly included via drm_buddy.h, drm_mm.h, or
> ttm/ttm_resource.h. Include drm_print.h explicitly.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/r/20251104101158.1cc9abcd@canb.auug.org.au
> Fixes: f6e8dc9edf96 ("drm: include drm_print.h where needed")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index 0d49f168a919..06b5d96e6eaf 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -14,6 +14,7 @@
> #include <drm/drm_drv.h>
> #include <drm/drm_fbdev_shmem.h>
> #include <drm/drm_gem_shmem_helper.h>
> +#include <drm/drm_print.h>
> #include <drm/drm_simple_kms_helper.h>
>
> #include "hyperv_drm.h"
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 6e6eb1c12a68..7978f8c8108c 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -19,6 +19,7 @@
> #include <drm/drm_probe_helper.h>
> #include <drm/drm_panic.h>
> #include <drm/drm_plane.h>
> +#include <drm/drm_print.h>
> #include <drm/drm_vblank.h>
> #include <drm/drm_vblank_helper.h>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/hyperv: include drm_print.h where needed
2025-11-04 10:27 ` Thomas Zimmermann
@ 2025-11-04 12:43 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2025-11-04 12:43 UTC (permalink / raw)
To: Thomas Zimmermann, dri-devel; +Cc: Stephen Rothwell
On Tue, 04 Nov 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 04.11.25 um 11:02 schrieb Jani Nikula:
>> hyperv_drm_drv.c and hyperv_drm_modeset.c depend on drm_print.h being
>> indirectly included via drm_buddy.h, drm_mm.h, or
>> ttm/ttm_resource.h. Include drm_print.h explicitly.
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Closes: https://lore.kernel.org/r/20251104101158.1cc9abcd@canb.auug.org.au
>> Fixes: f6e8dc9edf96 ("drm: include drm_print.h where needed")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks, pushed to drm-misc-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>> drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> index 0d49f168a919..06b5d96e6eaf 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> @@ -14,6 +14,7 @@
>> #include <drm/drm_drv.h>
>> #include <drm/drm_fbdev_shmem.h>
>> #include <drm/drm_gem_shmem_helper.h>
>> +#include <drm/drm_print.h>
>> #include <drm/drm_simple_kms_helper.h>
>>
>> #include "hyperv_drm.h"
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> index 6e6eb1c12a68..7978f8c8108c 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> @@ -19,6 +19,7 @@
>> #include <drm/drm_probe_helper.h>
>> #include <drm/drm_panic.h>
>> #include <drm/drm_plane.h>
>> +#include <drm/drm_print.h>
>> #include <drm/drm_vblank.h>
>> #include <drm/drm_vblank_helper.h>
>>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-04 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 10:02 [PATCH] drm/hyperv: include drm_print.h where needed Jani Nikula
2025-11-04 10:27 ` Thomas Zimmermann
2025-11-04 12:43 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox