* [PATCH] drm/panthor: Fix missing declaration for panthor_transparent_hugepage
@ 2026-05-03 14:42 gyeyoung
2026-05-07 8:05 ` Steven Price
0 siblings, 1 reply; 2+ messages in thread
From: gyeyoung @ 2026-05-03 14:42 UTC (permalink / raw)
To: Boris Brezillon, Steven Price, Liviu Dudau
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel, gyeyoung
sparse reports:
drivers/gpu/drm/panthor/panthor_drv.c:1805:6: warning: symbol 'panthor_transparent_hugepage' was not declared. Should it be static?
Make it clean.
Signed-off-by: gyeyoung <gye976@gmail.com>
---
drivers/gpu/drm/panthor/panthor_drv.c | 1 +
drivers/gpu/drm/panthor/panthor_drv.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 66996c9147c2..e8dc4096c1d2 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -31,6 +31,7 @@
#include "panthor_devfreq.h"
#include "panthor_device.h"
+#include "panthor_drv.h"
#include "panthor_fw.h"
#include "panthor_gem.h"
#include "panthor_gpu.h"
diff --git a/drivers/gpu/drm/panthor/panthor_drv.h b/drivers/gpu/drm/panthor/panthor_drv.h
index 1bc7ddbad23e..b81f21ed5398 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.h
+++ b/drivers/gpu/drm/panthor/panthor_drv.h
@@ -4,6 +4,8 @@
#ifndef __PANTHOR_DRV_H__
#define __PANTHOR_DRV_H__
+#include <linux/types.h>
+
extern bool panthor_transparent_hugepage;
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panthor: Fix missing declaration for panthor_transparent_hugepage
2026-05-03 14:42 [PATCH] drm/panthor: Fix missing declaration for panthor_transparent_hugepage gyeyoung
@ 2026-05-07 8:05 ` Steven Price
0 siblings, 0 replies; 2+ messages in thread
From: Steven Price @ 2026-05-07 8:05 UTC (permalink / raw)
To: gyeyoung, Boris Brezillon, Liviu Dudau
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, dri-devel, linux-kernel
On 03/05/2026 15:42, gyeyoung wrote:
> sparse reports:
> drivers/gpu/drm/panthor/panthor_drv.c:1805:6: warning: symbol 'panthor_transparent_hugepage' was not declared. Should it be static?
>
> Make it clean.
>
> Signed-off-by: gyeyoung <gye976@gmail.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Thanks, I'll push this to drm-misc-next.
Steve
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> drivers/gpu/drm/panthor/panthor_drv.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 66996c9147c2..e8dc4096c1d2 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -31,6 +31,7 @@
>
> #include "panthor_devfreq.h"
> #include "panthor_device.h"
> +#include "panthor_drv.h"
> #include "panthor_fw.h"
> #include "panthor_gem.h"
> #include "panthor_gpu.h"
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.h b/drivers/gpu/drm/panthor/panthor_drv.h
> index 1bc7ddbad23e..b81f21ed5398 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.h
> +++ b/drivers/gpu/drm/panthor/panthor_drv.h
> @@ -4,6 +4,8 @@
> #ifndef __PANTHOR_DRV_H__
> #define __PANTHOR_DRV_H__
>
> +#include <linux/types.h>
> +
> extern bool panthor_transparent_hugepage;
>
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-07 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 14:42 [PATCH] drm/panthor: Fix missing declaration for panthor_transparent_hugepage gyeyoung
2026-05-07 8:05 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox