* [PATCH] drm/connector: check if destroy function exist
@ 2026-05-21 10:33 Andreas Kemnade
2026-05-30 18:09 ` Andreas Kemnade
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2026-05-21 10:33 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, simona, lumag,
dri-devel, linux-kernel
Cc: Andreas Kemnade
Connectors might have not resources needed to be manually freed.
E.g. the drm_bridge_connector does not have such a callback.
Fixes: c12907be57b1 ("drm/bridge-connector: switch to using drmm allocations")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/gpu/drm/drm_connector.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 47dc53c4a738..d2dfc6e8f7d0 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -198,7 +198,9 @@ static void drm_connector_free(struct kref *kref)
struct drm_device *dev = connector->dev;
drm_mode_object_unregister(dev, &connector->base);
- connector->funcs->destroy(connector);
+
+ if (connector->funcs->destroy)
+ connector->funcs->destroy(connector);
}
void drm_connector_free_work_fn(struct work_struct *work)
@@ -216,7 +218,9 @@ void drm_connector_free_work_fn(struct work_struct *work)
llist_for_each_entry_safe(connector, n, freed, free_node) {
drm_mode_object_unregister(dev, &connector->base);
- connector->funcs->destroy(connector);
+
+ if (connector->funcs->destroy)
+ connector->funcs->destroy(connector);
}
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/connector: check if destroy function exist
2026-05-21 10:33 [PATCH] drm/connector: check if destroy function exist Andreas Kemnade
@ 2026-05-30 18:09 ` Andreas Kemnade
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Kemnade @ 2026-05-30 18:09 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, simona, lumag,
dri-devel, linux-kernel
A friendly ping.
Anything to do from my side?
On Thu, 21 May 2026 12:33:29 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> Connectors might have not resources needed to be manually freed.
> E.g. the drm_bridge_connector does not have such a callback.
>
> Fixes: c12907be57b1 ("drm/bridge-connector: switch to using drmm allocations")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gpu/drm/drm_connector.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 47dc53c4a738..d2dfc6e8f7d0 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -198,7 +198,9 @@ static void drm_connector_free(struct kref *kref)
> struct drm_device *dev = connector->dev;
>
> drm_mode_object_unregister(dev, &connector->base);
> - connector->funcs->destroy(connector);
> +
> + if (connector->funcs->destroy)
> + connector->funcs->destroy(connector);
> }
>
> void drm_connector_free_work_fn(struct work_struct *work)
> @@ -216,7 +218,9 @@ void drm_connector_free_work_fn(struct work_struct *work)
>
> llist_for_each_entry_safe(connector, n, freed, free_node) {
> drm_mode_object_unregister(dev, &connector->base);
> - connector->funcs->destroy(connector);
> +
> + if (connector->funcs->destroy)
> + connector->funcs->destroy(connector);
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-30 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-21 10:33 [PATCH] drm/connector: check if destroy function exist Andreas Kemnade
2026-05-30 18:09 ` Andreas Kemnade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox