[PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

[PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

[Julian Braha]

Currently, DRM_PANEL_HIMAX_HX83121A selects DRM_DISPLAY_DSC_HELPER
without also ensuring DRM_DISPLAY_HELPER is enabled, causing an unmet
dependency:

WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
  Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
  Selected by [m]:
  - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
  - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]

Many other DRM_PANEL_* options select DRM_DISPLAY_HELPER when selecting
DRM_DISPLAY_DSC_HELPER, let's do the same here.

This unmet dependency bug was found by kconfirm, a static analysis tool
for Kconfig.

Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index cfbfb371bc67..06bfcef35a72 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -253,6 +253,7 @@ config DRM_PANEL_HIMAX_HX83121A
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_HELPER
 	select DRM_DISPLAY_DSC_HELPER
 	select DRM_KMS_HELPER
 	help
-- 
2.54.0

Re: [PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] The commit fixes an unmet dependency warning for `DRM_PANEL_HIMAX_HX83121A` by adding `select DRM_DISPLAY_HELPER`, but fails to apply the same fix to `DRM_PANEL_ILITEK_ILI9882T` and `DRM_PANEL_SAMSUNG_S6E3HA8`. Both of these configs also select `DRM_DISPLAY_DSC_HELPER` without selecting its dependency `DRM_DISPLAY_HELPER`. Notably, `DRM_PANEL_ILITEK_ILI9882T` is explicitly listed in the Kconfig warning output cited in the commit message itself.
--

--- Patch [1]: [PATCH] drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A ---
commit 0826a9c22686833fa118df0f402fe8308a98fa6d
Author: Julian Braha <julianbraha@gmail.com>

drm/panel: fix unmet dependency bug for DRM_PANEL_HIMAX_HX83121A

This commit fixes an unmet dependency warning for DRM_PANEL_HIMAX_HX83121A
by selecting DRM_DISPLAY_HELPER. It addresses a warning where
DRM_DISPLAY_DSC_HELPER was selected without its dependencies being met.

>     WARNING: unmet direct dependencies detected for DRM_DISPLAY_DSC_HELPER
>       Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && DRM_DISPLAY_HELPER [=n]
>       Selected by [m]:
>       - DRM_PANEL_HIMAX_HX83121A [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>       - DRM_PANEL_ILITEK_ILI9882T [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_PANEL [=y] && OF [=y] && DRM_MIPI_DSI [=y] && BACKLIGHT_CLASS_DEVICE [=m]

[Severity: Medium]
This is a pre-existing issue, but should this patch also add the select 
DRM_DISPLAY_HELPER statement for DRM_PANEL_ILITEK_ILI9882T?

The warning message above indicates that DRM_PANEL_ILITEK_ILI9882T suffers
from the exact same unmet dependency.

Additionally, looking at drivers/gpu/drm/panel/Kconfig, it appears
DRM_PANEL_SAMSUNG_S6E3HA8 has the same issue:

config DRM_PANEL_SAMSUNG_S6E3HA8
	tristate "Samsung S6E3HA8 DSI video mode panel"
	...
	select DRM_DISPLAY_DSC_HELPER

Could we apply the same fix to both of these Kconfig options to completely
resolve the unmet dependency warnings across the panel drivers?

> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cfbfb371bc67e..06bfcef35a72e 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -253,6 +253,7 @@ config DRM_PANEL_HIMAX_HX83121A
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>  	select DRM_DISPLAY_DSC_HELPER
>  	select DRM_KMS_HELPER
>  	help

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711234230.2236041-1-julianbraha@gmail.com?part=1