Re: [PATCH 1/4] drm/fourcc: Add modifiers for AMD GFX6-8

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing asterisk prefix in the block comment for the '55:14' bitfield description.
--

--- Patch [1]: [PATCH 1/4] drm/fourcc: Add modifiers for AMD GFX6-8 ---
commit 215c005d35d2f0c0a64b0b0e5472a7d7f6157bd5
Author: Timur Kristóf <timur.kristof@gmail.com>

drm/fourcc: Add modifiers for AMD GFX6-8

This commit introduces DRM format modifiers for AMD GFX6-8 GPUs, the oldest
families supported by the amdgpu driver. It defines array modes, micro tile
modes, and macro tile parameters to facilitate sharing buffers between
processes and devices.

> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 3a4d4dc635bf5..d9be41fef478b 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
[ ... ]
> @@ -1646,36 +1646,69 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
[ ... ]
> + * DRM format modifier fields on AMD GPUs:
> + *     7:0 TILE_VERSION             Values are AMD_FMT_MOD_TILE_VER_*
> + *    12:8 TILE                     Values are AMD_FMT_MOD_TILE_<version>_*
> + *      13 DCC                      Delta Color Compression, supported on GFX8 and newer
>       55:14 (chip specific)          See below for details, depends on GFX block version
       ^^^^

[Severity: Low]
This isn't a bug, but it looks like the asterisk prefix is missing from this
line of the comment block. Should an asterisk be added here to match the rest
of the formatting?

> + *   63:56 Vendor                   Value is DRM_FORMAT_MOD_VENDOR_AMD
> + *
> + * Chip specific fields on Gfx9 and newer:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720142440.22076-1-timur.kristof@gmail.com?part=1