Re: [PATCH 4/4] drm/amd/display: Don't use tiling flags anymore

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] KUnit tests fail to compile and execute due to un-updated function signatures and test logic.
--

--- Patch [4]: [PATCH 4/4] drm/amd/display: Don't use tiling flags anymore ---
commit d732188b7192db7cd4cbe5558fd7f9823861ddf2
Author: Timur Kristóf <timur.kristof@gmail.com>

drm/amd/display: Don't use tiling flags anymore

All supported GPU generations now support DRM format modifiers.
Remove all code from amdgpu_dm that dealt with tiling flags.

> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h
> index 365e306a52e78..2b9b5f2507377 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h
> @@ -48,7 +48,6 @@ int amdgpu_dm_plane_fill_plane_buffer_attributes(struct amdgpu_device *adev,
>  				 const struct amdgpu_framebuffer *afb,
>  				 const enum surface_pixel_format format,
>  				 const enum dc_rotation_angle rotation,
> -				 const uint64_t tiling_flags,
>  				 struct dc_tiling_info *tiling_info,
>  				 struct plane_size *plane_size,

[Severity: Low]
Were the remaining KUnit tests in amdgpu_dm_plane_test.c updated to reflect
this signature change?

When compiling with CONFIG_DRM_AMD_DC_KUNIT_TEST=y, there appear to be build
failures because functions like dm_test_fill_plane_buffer_attributes_gfx8()
and dm_test_plane_attrs() still pass the extra tiling_flags (or 0) argument.

For example, in dm_test_fill_plane_buffer_attributes_gfx8():

	ret = amdgpu_dm_plane_fill_plane_buffer_attributes(adev, afb,
		SURFACE_PIXEL_FORMAT_GRPH_ARGB8888, ROTATION_ANGLE_0,
		tiling_flags, tiling_info, plane_size, dcc, address, true);

Additionally, does the test logic in
dm_test_fill_plane_buffer_attributes_gfx8() need to be updated to populate
afb->base.modifier instead of the removed tiling_flags so the test executes
correctly?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720142440.22076-1-timur.kristof@gmail.com?part=4