[PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"

[PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

This patch had been applied before the review has concluded. The panel
needs more specific handling than the one provided by panel-simple and
the intended compatible was supposed to contain both the display panel
name and the driver IC model number.

Moreover, the other compatible that didn't make it in the end landed in
the Qualcomm tree some time ago, instead of the one this revert
removes, so it's not even used.

See the link for reference.

This reverts commit a74c2e55ab66519ffa2069ac9ae83cd937bff4c4.

Link: https://lore.kernel.org/all/20260614-judyln-panel-v3-2-07f4134441bd@postmarketos.org/
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Paul, please resubmit your bindings patch with the proper compatible
and let's get it merged.
---
 Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 3d1cc11ba3aa..de722f45f862 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -206,8 +206,6 @@ properties:
       - lemaker,bl035-rgb-002
         # LG 7" (800x480 pixels) TFT LCD panel
       - lg,lb070wv8
-        # LG 6.1" (1440x3120) IPS LCD panel
-      - lg,sw49410
         # Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module
       - logictechno,lt161010-2nhc
         # Logic Technologies LT161010-2NHR 7" WVGA TFT Resistive Touch Module

---
base-commit: 944a035ecca915ae947905dcfb03f2b9dc6d032c
change-id: 20260911-topic-lg_sw49410_revert-3152e38ae8e7

Best regards,
--  
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Re: [PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reverting the 'lg,sw49410' compatible from panel-simple.yaml leaves the corresponding in-tree device tree node with an undocumented compatible string, causing a dtbs_check warning.
--

commit 28eecf951716dcb353efba4db6671dff19420f95
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"

This reverts the addition of the lg,sw49410 compatible string from the
panel-simple bindings. The commit states the panel needs more specific
handling and that the intended compatible was supposed to contain both
the display panel name and driver IC model number.

Link: https://lore.kernel.org/all/20260614-judyln-panel-v3-2-07f4134441bd@postmarketos.org/

> Moreover, the other compatible that didn't make it in the end landed in
> the Qualcomm tree some time ago, instead of the one this revert
> removes, so it's not even used.

[Severity: Medium]
Is this statement accurate?

Looking at arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts, this compatible
string appears to be actively used by the display_panel node:

arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts:display_panel {
        ...
        compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
        ...
}

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3d1cc11ba3aa4..de722f45f862a 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

[ ... ]

> @@ -206,8 +206,6 @@ properties:
>        - lemaker,bl035-rgb-002
>          # LG 7" (800x480 pixels) TFT LCD panel
>        - lg,lb070wv8
> -        # LG 6.1" (1440x3120) IPS LCD panel
> -      - lg,sw49410

[Severity: Medium]
Does removing this documentation leave the in-tree device tree node in
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts completely undocumented?

Running make dtbs_check on the tree with this revert applied will complain
about the undocumented compatible strings lg,sw49410-lh609qh1 and lg,sw49410
for this panel node, resulting in a schema validation error.

>          # Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module
>        - logictechno,lt161010-2nhc

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-topic-lg_sw49410_revert-v1-1-c9385a9e1926@oss.qualcomm.com?part=1

Re: [PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"

[Krzysztof Kozlowski]

On Fri, Sep 11, 2026 at 09:36:48AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> This patch had been applied before the review has concluded. The panel

"Commit foo bar had been applied..."

> needs more specific handling than the one provided by panel-simple and
> the intended compatible was supposed to contain both the display panel
> name and the driver IC model number.

You miss subject prefixes. It is "dt-bindings: dispaly: panel-simple:
Revert something".

> 
> Moreover, the other compatible that didn't make it in the end landed in
> the Qualcomm tree some time ago, instead of the one this revert
> removes, so it's not even used.
> 
> See the link for reference.
> 
> This reverts commit a74c2e55ab66519ffa2069ac9ae83cd937bff4c4.
> 
> Link: https://lore.kernel.org/all/20260614-judyln-panel-v3-2-07f4134441bd@postmarketos.org/
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Paul, please resubmit your bindings patch with the proper compatible
> and let's get it merged.

lg,sw49410 is already used, so instead new binding should be posted
moving this one from panel-simple.  Revert does not solve anything -
changes one warning into other one.

Best regards,
Krzysztof