dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] accel/ivpu: Synchronize context abort work with device reset
@ 2026-09-14  8:30 Karol Wachowski
  2026-09-15  8:46 ` Dawid Osuchowski
  0 siblings, 1 reply; 3+ messages in thread
From: Karol Wachowski @ 2026-09-14  8:30 UTC (permalink / raw)
  To: dri-devel
  Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski,
	dawid.osuchowski, Jozef Wludzik, Karol Wachowski

From: Jozef Wludzik <jozef.wludzik@intel.com>

Acquire pm->reset_lock in ivpu_context_abort_work_fn() to prevent it
from running concurrently with a device reset. If the lock cannot be
acquired immediately, skip the abort work to avoid racing with reset.
The device power management is disabled during reset.

Signed-off-by: Jozef Wludzik <jozef.wludzik@intel.com>
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
---
 drivers/accel/ivpu/ivpu_job.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c
index fa04f79e8f7b..245512bab523 100644
--- a/drivers/accel/ivpu/ivpu_job.c
+++ b/drivers/accel/ivpu/ivpu_job.c
@@ -1311,9 +1311,12 @@ void ivpu_context_abort_work_fn(struct work_struct *work)
 	unsigned long ctx_id;
 	unsigned long id;
 
-	if (drm_WARN_ON(&vdev->drm, pm_runtime_get_if_active(vdev->drm.dev) <= 0))
+	if (!down_read_trylock(&vdev->pm->reset_lock))
 		return;
 
+	if (drm_WARN_ON(&vdev->drm, pm_runtime_get_if_active(vdev->drm.dev) <= 0))
+		goto unlock;
+
 	if (vdev->fw->sched_mode == VPU_SCHEDULING_MODE_HW)
 		if (reset_engine_and_mark_faulty_contexts(vdev))
 			goto runtime_put;
@@ -1354,4 +1357,6 @@ void ivpu_context_abort_work_fn(struct work_struct *work)
 
 runtime_put:
 	pm_runtime_put_autosuspend(vdev->drm.dev);
+unlock:
+	up_read(&vdev->pm->reset_lock);
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] accel/ivpu: Synchronize context abort work with device reset
  2026-09-14  8:30 [PATCH] accel/ivpu: Synchronize context abort work with device reset Karol Wachowski
@ 2026-09-15  8:46 ` Dawid Osuchowski
  2026-09-17  8:08   ` Wachowski, Karol
  0 siblings, 1 reply; 3+ messages in thread
From: Dawid Osuchowski @ 2026-09-15  8:46 UTC (permalink / raw)
  To: Karol Wachowski, dri-devel
  Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski,
	Jozef Wludzik

On 2026-09-14 10:30 AM, Karol Wachowski wrote:
> From: Jozef Wludzik <jozef.wludzik@intel.com>
> 
> Acquire pm->reset_lock in ivpu_context_abort_work_fn() to prevent it
> from running concurrently with a device reset. If the lock cannot be
> acquired immediately, skip the abort work to avoid racing with reset.
> The device power management is disabled during reset.
> 

Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>

> Signed-off-by: Jozef Wludzik <jozef.wludzik@intel.com>
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_job.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] accel/ivpu: Synchronize context abort work with device reset
  2026-09-15  8:46 ` Dawid Osuchowski
@ 2026-09-17  8:08   ` Wachowski, Karol
  0 siblings, 0 replies; 3+ messages in thread
From: Wachowski, Karol @ 2026-09-17  8:08 UTC (permalink / raw)
  To: Dawid Osuchowski, dri-devel
  Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski,
	Jozef Wludzik

On 15-Sep-26 10:46, Dawid Osuchowski wrote:
> On 2026-09-14 10:30 AM, Karol Wachowski wrote:
>> From: Jozef Wludzik <jozef.wludzik@intel.com>
>>
>> Acquire pm->reset_lock in ivpu_context_abort_work_fn() to prevent it
>> from running concurrently with a device reset. If the lock cannot be
>> acquired immediately, skip the abort work to avoid racing with reset.
>> The device power management is disabled during reset.
>>
> 
> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>

Thanks, applied to drm-misc-next.


>> Signed-off-by: Jozef Wludzik <jozef.wludzik@intel.com>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> ---
>>   drivers/accel/ivpu/ivpu_job.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-17  8:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-14  8:30 [PATCH] accel/ivpu: Synchronize context abort work with device reset Karol Wachowski
2026-09-15  8:46 ` Dawid Osuchowski
2026-09-17  8:08   ` Wachowski, Karol

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox