[PATCH] staging: fbtft: fbtft-bus: remove space before close parenthesis

[PATCH] staging: fbtft: fbtft-bus: remove space before close parenthesis

[UgwuRhema]

Fix checkpatch.pl errors regarding prohibited spaces before closing
parentheses in fbtft-bus.c.

Signed-off-by: UgwuRhema <hikarialiyev@gmail.com>
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 30e436ff1..409770891 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
2.55.0

Re: [PATCH] staging: fbtft: fbtft-bus: remove space before close parenthesis

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] staging/fbtft: build failure due to missing macro argument
--

commit b334de9ec8bff5176150c0abed3949be6aea7f81
Author: UgwuRhema <hikarialiyev@gmail.com>

staging: fbtft: fbtft-bus: remove space before close parenthesis

This commit removes spaces before closing parentheses in fbtft-bus.c to fix
warnings from checkpatch.pl.

> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4c..409770891c548 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out:									      \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)

[Severity: Low]
Does this cause a build failure? The macro define_fbtft_write_reg is
defined to take exactly 4 parameters:

#define define_fbtft_write_reg(func, buffer_type, data_type, modifier)

Removing the trailing comma means the macro is now invoked with only 3
arguments, which violates C preprocessor rules and results in a fatal
compiler error.

>  define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)

[Severity: Low]
Does this also cause a preprocessor error for the same reason? The 4th
argument is missing here as well.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921181350.89925-1-hikarialiyev@gmail.com?part=1