[PATCH] drm/panel: Set max rate for Innolux p079x panels

[PATCH] drm/panel: Set max rate for Innolux p079x panels

[Linus Walleij]

After adding the hs_rate and lp_rate fields to the DSI device
we need to populate these accordingly so display drivers can
respect them.

Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index ca4ae45dd307..2013cd3c58ba 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -518,6 +518,9 @@ static int innolux_panel_probe(struct mipi_dsi_device *dsi)
 	dsi->mode_flags = desc->flags;
 	dsi->format = desc->format;
 	dsi->lanes = desc->lanes;
+	/* This is presumably the HS rate */
+	dsi->hs_rate = desc->mode->clock * 1000;
+	/* FIXME: LP rate not specified */
 
 	err = innolux_panel_add(dsi, desc);
 	if (err < 0)
-- 
2.17.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: Set max rate for Innolux p079x panels

[Heiko Stübner]

Hi Linus,

Am Mittwoch, 14. November 2018, 12:42:54 CET schrieb Linus Walleij:
> After adding the hs_rate and lp_rate fields to the DSI device
> we need to populate these accordingly so display drivers can
> respect them.
> 
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Chris Zhong <zyw@rock-chips.com>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

While my understanding of DSI is marginal, the display on my
scarlet (p097pfg variant in the driver) still comes up, so

Tested-by: Heiko Stuebner <heiko@sntech.de>


Heiko


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: Set max rate for Innolux p079x panels

[Linus Walleij]

On Wed, Nov 14, 2018 at 3:31 PM Heiko Stübner <heiko@sntech.de> wrote:
> Am Mittwoch, 14. November 2018, 12:42:54 CET schrieb Linus Walleij:
> > After adding the hs_rate and lp_rate fields to the DSI device
> > we need to populate these accordingly so display drivers can
> > respect them.
> >
> > Cc: Andrzej Hajda <a.hajda@samsung.com>
> > Cc: Chris Zhong <zyw@rock-chips.com>
> > Cc: Lin Huang <hl@rock-chips.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> While my understanding of DSI is marginal, the display on my
> scarlet (p097pfg variant in the driver) still comes up, so
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>

It's mainly that we want displays to report their speed capabilities.

It is up to the display drivers to make use of it to throttle the lanes,
I think they all use some safe default as of now.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel