* [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-10-16 16:58 Fabrizio Castro
2018-10-17 6:51 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Fabrizio Castro @ 2018-10-16 16:58 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, David Airlie
Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven, dri-devel,
Biju Das, linux-renesas-soc, Simon Horman
Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1->v2:
* Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC
* Reworked comment
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 084f58d..d8a02c4 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -77,6 +77,33 @@ static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
},
};
+static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
+ .gen = 2,
+ .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+ | RCAR_DU_FEATURE_EXT_CTRL_REGS
+ | RCAR_DU_FEATURE_INTERLACED
+ | RCAR_DU_FEATURE_TVM_SYNC,
+ .channels_mask = BIT(1) | BIT(0),
+ .routes = {
+ /*
+ * R8A77470 has two RGB outputs, one LVDS output, and
+ * one (currently unsupported) analog video output
+ */
+ [RCAR_DU_OUTPUT_DPAD0] = {
+ .possible_crtcs = BIT(0),
+ .port = 0,
+ },
+ [RCAR_DU_OUTPUT_DPAD1] = {
+ .possible_crtcs = BIT(1),
+ .port = 1,
+ },
+ [RCAR_DU_OUTPUT_LVDS0] = {
+ .possible_crtcs = BIT(0) | BIT(1),
+ .port = 2,
+ },
+ },
+};
+
static const struct rcar_du_device_info rcar_du_r8a7779_info = {
.gen = 2,
.features = RCAR_DU_FEATURE_INTERLACED
@@ -342,6 +369,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
+ { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
2018-10-16 16:58 [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Fabrizio Castro
@ 2018-10-17 6:51 ` Laurent Pinchart
2018-11-22 16:03 ` Fabrizio Castro
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2018-10-17 6:51 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Simon Horman, Chris Paterson, Geert Uytterhoeven, David Airlie,
dri-devel, Biju Das, linux-renesas-soc, Kieran Bingham
Hi Fabrizio,
Thank you for the patch.
On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote:
> Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> ---
> v1->v2:
> * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC
> * Reworked comment
This looks all good, applied to my tree.
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -77,6 +77,33 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7745_info = { },
> };
>
> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> + .gen = 2,
> + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> + | RCAR_DU_FEATURE_INTERLACED
> + | RCAR_DU_FEATURE_TVM_SYNC,
> + .channels_mask = BIT(1) | BIT(0),
> + .routes = {
> + /*
> + * R8A77470 has two RGB outputs, one LVDS output, and
> + * one (currently unsupported) analog video output
> + */
> + [RCAR_DU_OUTPUT_DPAD0] = {
> + .possible_crtcs = BIT(0),
> + .port = 0,
> + },
> + [RCAR_DU_OUTPUT_DPAD1] = {
> + .possible_crtcs = BIT(1),
> + .port = 1,
> + },
> + [RCAR_DU_OUTPUT_LVDS0] = {
> + .possible_crtcs = BIT(0) | BIT(1),
> + .port = 2,
> + },
> + },
> +};
> +
> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> .gen = 2,
> .features = RCAR_DU_FEATURE_INTERLACED
> @@ -342,6 +369,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a7799x_info = { static const struct of_device_id
> rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
2018-10-17 6:51 ` Laurent Pinchart
@ 2018-11-22 16:03 ` Fabrizio Castro
2018-11-23 12:07 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Fabrizio Castro @ 2018-11-22 16:03 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Simon Horman, Chris Paterson, Geert Uytterhoeven, David Airlie,
dri-devel@lists.freedesktop.org, Biju Das,
linux-renesas-soc@vger.kernel.org, Kieran Bingham
Hello Laurent,
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 17 October 2018 07:52
> Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote:
> > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > ---
> > v1->v2:
> > * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC
> > * Reworked comment
>
> This looks all good, applied to my tree.
It looks like I can't find the patch, which tree is it?
Thanks,
Fab
>
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -77,6 +77,33 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7745_info = { },
> > };
> >
> > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> > +.gen = 2,
> > +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> > + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> > + | RCAR_DU_FEATURE_INTERLACED
> > + | RCAR_DU_FEATURE_TVM_SYNC,
> > +.channels_mask = BIT(1) | BIT(0),
> > +.routes = {
> > +/*
> > + * R8A77470 has two RGB outputs, one LVDS output, and
> > + * one (currently unsupported) analog video output
> > + */
> > +[RCAR_DU_OUTPUT_DPAD0] = {
> > +.possible_crtcs = BIT(0),
> > +.port = 0,
> > +},
> > +[RCAR_DU_OUTPUT_DPAD1] = {
> > +.possible_crtcs = BIT(1),
> > +.port = 1,
> > +},
> > +[RCAR_DU_OUTPUT_LVDS0] = {
> > +.possible_crtcs = BIT(0) | BIT(1),
> > +.port = 2,
> > +},
> > +},
> > +};
> > +
> > static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> > .gen = 2,
> > .features = RCAR_DU_FEATURE_INTERLACED
> > @@ -342,6 +369,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a7799x_info = { static const struct of_device_id
> > rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
>
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
2018-11-22 16:03 ` Fabrizio Castro
@ 2018-11-23 12:07 ` Laurent Pinchart
2018-11-23 12:32 ` Fabrizio Castro
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2018-11-23 12:07 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Simon Horman, Chris Paterson, Geert Uytterhoeven, David Airlie,
dri-devel@lists.freedesktop.org, Biju Das,
linux-renesas-soc@vger.kernel.org, Kieran Bingham
Hi Fabrizio,
On Thursday, 22 November 2018 18:03:44 EET Fabrizio Castro wrote:
> On 17 October 2018 07:52 Laurent Pinchart wrote:
> > On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote:
> > > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> >>
> >> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>
> >> ---
> >> v1->v2:
> >> * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC
> >> * Reworked comment
> >
> > This looks all good, applied to my tree.
>
> It looks like I can't find the patch, which tree is it?
The patch can be found in git://linuxtv.org/pinchartl/media.git drm/du/next.
> >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -77,6 +77,33 @@ static const struct rcar_du_device_info
> >> rzg1_du_r8a7745_info = { },
> >> };
> >>
> >> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> >> +.gen = 2,
> >> +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> >> + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> >> + | RCAR_DU_FEATURE_INTERLACED
> >> + | RCAR_DU_FEATURE_TVM_SYNC,
> >> +.channels_mask = BIT(1) | BIT(0),
> >> +.routes = {
> >> +/*
> >> + * R8A77470 has two RGB outputs, one LVDS output, and
> >> + * one (currently unsupported) analog video output
> >> + */
> >> +[RCAR_DU_OUTPUT_DPAD0] = {
> >> +.possible_crtcs = BIT(0),
> >> +.port = 0,
> >> +},
> >> +[RCAR_DU_OUTPUT_DPAD1] = {
> >> +.possible_crtcs = BIT(1),
> >> +.port = 1,
> >> +},
> >> +[RCAR_DU_OUTPUT_LVDS0] = {
> >> +.possible_crtcs = BIT(0) | BIT(1),
> >> +.port = 2,
> >> +},
> >> +},
> >> +};
> >> +
> >> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> >> .gen = 2,
> >> .features = RCAR_DU_FEATURE_INTERLACED
> >> @@ -342,6 +369,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a7799x_info = { static const struct of_device_id
> >> rcar_du_of_table[] = {
> >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >> +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >> },
> >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> >> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> >> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
2018-11-23 12:07 ` Laurent Pinchart
@ 2018-11-23 12:32 ` Fabrizio Castro
0 siblings, 0 replies; 5+ messages in thread
From: Fabrizio Castro @ 2018-11-23 12:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Simon Horman, Chris Paterson, Geert Uytterhoeven, David Airlie,
dri-devel@lists.freedesktop.org, Biju Das,
linux-renesas-soc@vger.kernel.org, Kieran Bingham
Thank you Laurent.
Cheers,
Fab
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 23 November 2018 12:07
> Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support
>
> Hi Fabrizio,
>
> On Thursday, 22 November 2018 18:03:44 EET Fabrizio Castro wrote:
> > On 17 October 2018 07:52 Laurent Pinchart wrote:
> > > On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote:
> > > > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> > >>
> > >> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >>
> > >> ---
> > >> v1->v2:
> > >> * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC
> > >> * Reworked comment
> > >
> > > This looks all good, applied to my tree.
> >
> > It looks like I can't find the patch, which tree is it?
>
> The patch can be found in git://linuxtv.org/pinchartl/media.git drm/du/next.
>
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++
> > >> 1 file changed, 28 insertions(+)
> > >>
> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644
> > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> @@ -77,6 +77,33 @@ static const struct rcar_du_device_info
> > >> rzg1_du_r8a7745_info = { },
> > >> };
> > >>
> > >> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> > >> +.gen = 2,
> > >> +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> > >> + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> > >> + | RCAR_DU_FEATURE_INTERLACED
> > >> + | RCAR_DU_FEATURE_TVM_SYNC,
> > >> +.channels_mask = BIT(1) | BIT(0),
> > >> +.routes = {
> > >> +/*
> > >> + * R8A77470 has two RGB outputs, one LVDS output, and
> > >> + * one (currently unsupported) analog video output
> > >> + */
> > >> +[RCAR_DU_OUTPUT_DPAD0] = {
> > >> +.possible_crtcs = BIT(0),
> > >> +.port = 0,
> > >> +},
> > >> +[RCAR_DU_OUTPUT_DPAD1] = {
> > >> +.possible_crtcs = BIT(1),
> > >> +.port = 1,
> > >> +},
> > >> +[RCAR_DU_OUTPUT_LVDS0] = {
> > >> +.possible_crtcs = BIT(0) | BIT(1),
> > >> +.port = 2,
> > >> +},
> > >> +},
> > >> +};
> > >> +
> > >> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> > >> .gen = 2,
> > >> .features = RCAR_DU_FEATURE_INTERLACED
> > >> @@ -342,6 +369,7 @@ static const struct rcar_du_device_info
> > >> rcar_du_r8a7799x_info = { static const struct of_device_id
> > >> rcar_du_of_table[] = {
> > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > >> +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> > >> },
> > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > >> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> > >> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-23 12:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-16 16:58 [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Fabrizio Castro
2018-10-17 6:51 ` Laurent Pinchart
2018-11-22 16:03 ` Fabrizio Castro
2018-11-23 12:07 ` Laurent Pinchart
2018-11-23 12:32 ` Fabrizio Castro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox