From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
To: harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, daniel@ffwll.ch,
airlied@gmail.com, Qingqing.Zhuo@amd.com, alvin.lee2@amd.com,
wenjing.liu@amd.com, jun.lei@amd.com, Samson.Tam@amd.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: avoid variable reinitialization
Date: Sat, 4 Nov 2023 18:32:25 +0530 [thread overview]
Message-ID: <2bb714be-9511-4f79-a633-9f4467a6dcba@gmail.com> (raw)
In-Reply-To: <744beb05-1327-401e-a961-edfe63bd8927@gmail.com>
On 30/10/23 20:17, Bragatheswaran Manickavel wrote:
>
> On 24/10/23 23:41, Bragatheswaran Manickavel wrote:
>> The member variable enable_hpo_pg_support is already initialized
>> and hence the reinitialization instruction can be removed. Issue
>> identified using the doubleinit.cocci Coccinelle semantic patch script.
>>
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> index 99d55b958977..1fd9df8da09c 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> @@ -739,7 +739,6 @@ static const struct dc_debug_options
>> debug_defaults_drv = {
>> .disable_boot_optimizations = false,
>> .disable_unbounded_requesting = false,
>> .disable_mem_low_power = false,
>> - .enable_hpo_pg_support = false,
>> //must match enable_single_display_2to1_odm_policy to support
>> dynamic ODM transitions
>> .enable_double_buffered_dsc_pg_support = true,
>> .enable_dp_dig_pixel_rate_div_policy = 1,
>
>
> just a friendly ping
>
> Thanks,
> Bragathe
>
Could someone help me in reviewing this changes ?
Thanks,
Bragathe
next prev parent reply other threads:[~2023-11-04 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 18:11 [PATCH] drm/amd/display: avoid variable reinitialization Bragatheswaran Manickavel
2023-10-30 14:47 ` Bragatheswaran Manickavel
2023-11-04 13:02 ` Bragatheswaran Manickavel [this message]
2023-11-06 18:35 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-01-15 9:32 Deepak R Varma
2023-01-16 17:58 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb714be-9511-4f79-a633-9f4467a6dcba@gmail.com \
--to=bragathemanick0908@gmail.com \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Samson.Tam@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jun.lei@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox