* [PATCH] drm/amd/display: avoid variable reinitialization
@ 2023-01-15 9:32 Deepak R Varma
2023-01-16 17:58 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: Deepak R Varma @ 2023-01-15 9:32 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
amd-gfx, dri-devel, linux-kernel
Cc: Praveen Kumar, Saurabh Singh Sengar
The member variable set_odm_combine is already initialized and hence the
reinitialization instruction can be removed. Issue identified using the
dubleinit.cocci Coccinelle semantic patch script.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index 41edbd64ea21..777d8efee977 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
.get_hw_timing = optc1_get_hw_timing,
.init_odm = optc3_init_odm,
.set_odm_bypass = optc314_set_odm_bypass,
- .set_odm_combine = optc314_set_odm_combine,
.set_h_timing_div_manual_mode = optc314_set_h_timing_div_manual_mode,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: avoid variable reinitialization
2023-01-15 9:32 Deepak R Varma
@ 2023-01-16 17:58 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2023-01-16 17:58 UTC (permalink / raw)
To: Deepak R Varma
Cc: Saurabh Singh Sengar, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
linux-kernel, amd-gfx, Praveen Kumar, dri-devel, Alex Deucher,
Christian König
This is already fixed.
Thanks,
Alex
On Sun, Jan 15, 2023 at 4:32 AM Deepak R Varma <drv@mailo.com> wrote:
>
> The member variable set_odm_combine is already initialized and hence the
> reinitialization instruction can be removed. Issue identified using the
> dubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index 41edbd64ea21..777d8efee977 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
> .get_hw_timing = optc1_get_hw_timing,
> .init_odm = optc3_init_odm,
> .set_odm_bypass = optc314_set_odm_bypass,
> - .set_odm_combine = optc314_set_odm_combine,
> .set_h_timing_div_manual_mode = optc314_set_h_timing_div_manual_mode,
> };
>
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: avoid variable reinitialization
@ 2023-10-24 18:11 Bragatheswaran Manickavel
2023-10-30 14:47 ` Bragatheswaran Manickavel
2023-11-06 18:35 ` Alex Deucher
0 siblings, 2 replies; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-10-24 18:11 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, daniel, airlied, Qingqing.Zhuo,
alvin.lee2, wenjing.liu, jun.lei, Samson.Tam
Cc: linux-kernel, dri-devel, amd-gfx, Bragatheswaran Manickavel
The member variable enable_hpo_pg_support is already initialized
and hence the reinitialization instruction can be removed. Issue
identified using the doubleinit.cocci Coccinelle semantic patch script.
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
index 99d55b958977..1fd9df8da09c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
@@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
.disable_boot_optimizations = false,
.disable_unbounded_requesting = false,
.disable_mem_low_power = false,
- .enable_hpo_pg_support = false,
//must match enable_single_display_2to1_odm_policy to support dynamic ODM transitions
.enable_double_buffered_dsc_pg_support = true,
.enable_dp_dig_pixel_rate_div_policy = 1,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: avoid variable reinitialization
2023-10-24 18:11 [PATCH] drm/amd/display: avoid variable reinitialization Bragatheswaran Manickavel
@ 2023-10-30 14:47 ` Bragatheswaran Manickavel
2023-11-04 13:02 ` Bragatheswaran Manickavel
2023-11-06 18:35 ` Alex Deucher
1 sibling, 1 reply; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-10-30 14:47 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, daniel, airlied, Qingqing.Zhuo,
alvin.lee2, wenjing.liu, jun.lei, Samson.Tam
Cc: dri-devel, amd-gfx, linux-kernel
On 24/10/23 23:41, Bragatheswaran Manickavel wrote:
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> index 99d55b958977..1fd9df8da09c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> @@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
> .disable_boot_optimizations = false,
> .disable_unbounded_requesting = false,
> .disable_mem_low_power = false,
> - .enable_hpo_pg_support = false,
> //must match enable_single_display_2to1_odm_policy to support dynamic ODM transitions
> .enable_double_buffered_dsc_pg_support = true,
> .enable_dp_dig_pixel_rate_div_policy = 1,
just a friendly ping
Thanks,
Bragathe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: avoid variable reinitialization
2023-10-30 14:47 ` Bragatheswaran Manickavel
@ 2023-11-04 13:02 ` Bragatheswaran Manickavel
0 siblings, 0 replies; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-11-04 13:02 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, daniel, airlied, Qingqing.Zhuo,
alvin.lee2, wenjing.liu, jun.lei, Samson.Tam
Cc: dri-devel, amd-gfx, linux-kernel
On 30/10/23 20:17, Bragatheswaran Manickavel wrote:
>
> On 24/10/23 23:41, Bragatheswaran Manickavel wrote:
>> The member variable enable_hpo_pg_support is already initialized
>> and hence the reinitialization instruction can be removed. Issue
>> identified using the doubleinit.cocci Coccinelle semantic patch script.
>>
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> index 99d55b958977..1fd9df8da09c 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
>> @@ -739,7 +739,6 @@ static const struct dc_debug_options
>> debug_defaults_drv = {
>> .disable_boot_optimizations = false,
>> .disable_unbounded_requesting = false,
>> .disable_mem_low_power = false,
>> - .enable_hpo_pg_support = false,
>> //must match enable_single_display_2to1_odm_policy to support
>> dynamic ODM transitions
>> .enable_double_buffered_dsc_pg_support = true,
>> .enable_dp_dig_pixel_rate_div_policy = 1,
>
>
> just a friendly ping
>
> Thanks,
> Bragathe
>
Could someone help me in reviewing this changes ?
Thanks,
Bragathe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: avoid variable reinitialization
2023-10-24 18:11 [PATCH] drm/amd/display: avoid variable reinitialization Bragatheswaran Manickavel
2023-10-30 14:47 ` Bragatheswaran Manickavel
@ 2023-11-06 18:35 ` Alex Deucher
1 sibling, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2023-11-06 18:35 UTC (permalink / raw)
To: Bragatheswaran Manickavel
Cc: amd-gfx, dri-devel, sunpeng.li, Qingqing.Zhuo, Xinhui.Pan,
Rodrigo.Siqueira, linux-kernel, Samson.Tam, wenjing.liu,
alvin.lee2, alexander.deucher, jun.lei, christian.koenig
Applied. Thanks!
On Tue, Oct 24, 2023 at 2:11 PM Bragatheswaran Manickavel
<bragathemanick0908@gmail.com> wrote:
>
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> index 99d55b958977..1fd9df8da09c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> @@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
> .disable_boot_optimizations = false,
> .disable_unbounded_requesting = false,
> .disable_mem_low_power = false,
> - .enable_hpo_pg_support = false,
> //must match enable_single_display_2to1_odm_policy to support dynamic ODM transitions
> .enable_double_buffered_dsc_pg_support = true,
> .enable_dp_dig_pixel_rate_div_policy = 1,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-06 18:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 18:11 [PATCH] drm/amd/display: avoid variable reinitialization Bragatheswaran Manickavel
2023-10-30 14:47 ` Bragatheswaran Manickavel
2023-11-04 13:02 ` Bragatheswaran Manickavel
2023-11-06 18:35 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-01-15 9:32 Deepak R Varma
2023-01-16 17:58 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox