From: "Sharma, Jitendra" <shajit@codeaurora.org>
To: Wolfram Sang <wsa@the-dreams.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, Wolfram Sang <wsa@sang-engineering.com>
Subject: Re: [PATCH v2] drm/bridge: adv7511: Remove unused code blocks
Date: Thu, 20 Oct 2016 14:56:36 +0530 [thread overview]
Message-ID: <2f4e7ee7-8fe2-7960-664c-1bc5c393bd7c@codeaurora.org> (raw)
In-Reply-To: <20161020084535.GA1442@katana>
[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]
Thanks for comments.
On 10/20/2016 2:15 PM, Wolfram Sang wrote:
>>> IMO it would be better to use id->driver_data unconditionally and save a
>>> call to of_device_get_match_data()
>>> What would you suggest to move ahead?
>> I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's
>> opinion on this (CC'ed).
> IIUC: I'd suggest to leave it as it is.
>
> There are people working on removing the quirky fallback to
> i2c_device_id in case of_compatible is not provided. If that gets
> mainline, you don't have i2c_device_id anymore with DT matching. So all
> binding methods should be self-contained.
ok
Should we leave as it is, redundant if-else code block also, or fix it
as posted in patch v2
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #1.2: Type: text/html, Size: 1835 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-20 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 10:09 [PATCH] drm/bridge: adv7511: Remove unused code blocks Jitendra Sharma
2016-10-18 13:07 ` Laurent Pinchart
2016-10-19 4:34 ` Sharma, Jitendra
2016-10-19 11:42 ` [PATCH v2] " Jitendra Sharma
2016-10-19 11:51 ` Laurent Pinchart
2016-10-19 13:07 ` Sharma, Jitendra
2016-10-19 13:20 ` Archit Taneja
2016-10-19 13:33 ` Laurent Pinchart
2016-10-19 13:41 ` Sharma, Jitendra
2016-10-20 7:35 ` Laurent Pinchart
2016-10-20 8:45 ` Wolfram Sang
2016-10-20 9:26 ` Sharma, Jitendra [this message]
2016-10-20 9:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4e7ee7-8fe2-7960-664c-1bc5c393bd7c@codeaurora.org \
--to=shajit@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox