From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: shmob_drm: Check clk_prepare_enable() return value
Date: Wed, 04 Dec 2013 02:38:21 +0100 [thread overview]
Message-ID: <37481163.oH5TkQcYhz@avalon> (raw)
In-Reply-To: <20131203095923.GD21178@ulmo.nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 963 bytes --]
Hi Thierry,
On Tuesday 03 December 2013 10:59:24 Thierry Reding wrote:
> On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote:
> [...]
>
> > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> > b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> [...]
>
> > @@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc
> > *scrtc)
> > return;
> >
> > /* Enable clocks before accessing the hardware. */
> > - shmob_drm_clk_on(sdev);
> > + ret = shmob_drm_clk_on(sdev);
> > + if (ret < 0)
> > + return;
>
> Perhaps this should be printing an error or using WARN_ON()? Otherwise
> it might be very difficult to diagnose what's going wrong.
That's a good point. In practice, as the driver always uses a Renesas SoC MSTP
clock, the clock code will print a message to the kernel log though, so I'm
not sure whether we should duplicate that here. If you think we should I'll
submit a new patch.
--
Regards,
Laurent Pinchart
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-12-04 1:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 0:52 [PATCH] drm: shmob_drm: Check clk_prepare_enable() return value Laurent Pinchart
2013-12-03 9:59 ` Thierry Reding
2013-12-04 1:38 ` Laurent Pinchart [this message]
2013-12-04 10:01 ` Thierry Reding
2013-12-04 14:37 ` Laurent Pinchart
2013-12-04 15:59 ` Thierry Reding
2013-12-04 16:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37481163.oH5TkQcYhz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox