From: Helge Deller <deller@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jilin Yuan" <yuanjilin@cdjrlc.com>
Cc: linux-fbdev@vger.kernel.org, kernel@pengutronix.de,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] video: fbdev: ssd1307fb: Print the PWM's label instead of its number
Date: Mon, 31 Jul 2023 14:42:28 +0200 [thread overview]
Message-ID: <3d06d451-613b-e872-89f9-c1ffffde2b47@gmx.de> (raw)
In-Reply-To: <20230728145824.616687-3-u.kleine-koenig@pengutronix.de>
On 7/28/23 16:58, Uwe Kleine-König wrote:
> struct pwm_device::pwm is a write-only variable in the pwm core and used
> nowhere apart from this and another dev_dbg. So it isn't useful to
> identify the used PWM. Emit the PWM's label instead in the debug
> message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/ssd1307fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 11c373798279..46881a691549 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> /* Enable the PWM */
> pwm_enable(par->pwm);
>
> - dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n",
> - par->pwm->pwm, pwm_get_period(par->pwm));
> + dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n",
> + par->pwm->label, pwm_get_period(par->pwm));
> }
>
> /* Set initial contrast */
next prev parent reply other threads:[~2023-07-31 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:58 [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
2023-07-28 14:58 ` [PATCH 1/3] drm/ssd130x: Print the PWM's label instead of its number Uwe Kleine-König
2023-07-28 15:39 ` Javier Martinez Canillas
2023-07-28 14:58 ` [PATCH 2/3] video: fbdev: ssd1307fb: " Uwe Kleine-König
2023-07-28 15:40 ` Javier Martinez Canillas
2023-09-09 14:38 ` Javier Martinez Canillas
2023-09-09 20:21 ` Uwe Kleine-König
2023-09-10 6:58 ` Javier Martinez Canillas
2023-07-31 12:42 ` Helge Deller [this message]
2023-08-01 8:54 ` Andy Shevchenko
2023-11-13 21:28 ` [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d06d451-613b-e872-89f9-c1ffffde2b47@gmx.de \
--to=deller@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox