From: Javier Martinez Canillas <javierm@redhat.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/ssd130x: Print the PWM's label instead of its number
Date: Fri, 28 Jul 2023 17:39:55 +0200 [thread overview]
Message-ID: <87o7jwxcxg.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230728145824.616687-2-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
Hello Uwe,
> struct pwm_device::pwm is a write-only variable in the pwm core and used
> nowhere apart from this and another dev_dbg. So it isn't useful to
> identify the used PWM. Emit the PWM's label instead in the debug
> message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-07-28 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:58 [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
2023-07-28 14:58 ` [PATCH 1/3] drm/ssd130x: Print the PWM's label instead of its number Uwe Kleine-König
2023-07-28 15:39 ` Javier Martinez Canillas [this message]
2023-07-28 14:58 ` [PATCH 2/3] video: fbdev: ssd1307fb: " Uwe Kleine-König
2023-07-28 15:40 ` Javier Martinez Canillas
2023-09-09 14:38 ` Javier Martinez Canillas
2023-09-09 20:21 ` Uwe Kleine-König
2023-09-10 6:58 ` Javier Martinez Canillas
2023-07-31 12:42 ` Helge Deller
2023-08-01 8:54 ` Andy Shevchenko
2023-11-13 21:28 ` [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7jwxcxg.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox