Re: [PATCH] android: libdrm_platform: add liblog shared dependency

[Robert Foss <robert.foss@collabora.com>]

Hey Mauro,

On 3/18/19 9:38 AM, Mauro Rossi wrote:
> Hi Robert,
> 
> On Mon, Mar 18, 2019 at 9:21 AM Robert Foss <robert.foss@collabora.com> wrote:
>>
>> On a second note, this does not apply on libdrm/master due
>> to:
>>
>> LOCAL_SHARED_LIBRARIES := \
>>          libcutils
> 
> Sorry, we have an additional Google patch, not present in libdrm/master
> that adds libdrm_platform module, but it is for a specific Google issue. [1]
> 
> However with libdrm module we have both liblog and libcutils shared dependencies
> 
> [1] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commit;h=8ccbfeab9fb2bddf4585339a0bcbea2f1e3ffa1e

Do you know if [1] causes incompatibility issues with earlier android verions?
If not I would suggest upstreaming it too.

> 
> Mauro
> 
>>
>> My thinking is that libcutils probably can be replaced with liblog,
>> but I'm not 100% sure.
>>
>>
>> Rob.
>>
>> On 3/18/19 9:09 AM, Robert Foss wrote:
>>> This is probably a good idea!
>>>
>>>
>>> Reviewed-by: Robert Foss <robert.foss@collabora.com>
>>>
>>> On 3/17/19 9:54 PM, Mauro Rossi wrote:
>>>> Hi,
>>>> I used the option --subject-prefix="PATCH libdrm"
>>>> but it did not go as expected.
>>>>
>>>> Anyway, the patch is for Android build of mesa/drm
>>>> Mauro
>>>>
>>>> On Sun, Mar 17, 2019 at 9:50 PM Mauro Rossi <issor.oruam@gmail.com> wrote:
>>>>>
>>>>> Fixes the following building error:
>>>>>
>>>>> FAILED:
>>>>> $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates/LINKED/libdrm_platform.so
>>>>>
>>>>> ...
>>>>> external/libdrm/xf86drm.c:146: error: undefined reference to
>>>>> '__android_log_vprint'
>>>>> clang.real: error: linker command failed with exit code 1 (use -v to see
>>>>> invocation)
>>>>>
>>>>> Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
>>>>> ---
>>>>>    Android.mk | 3 +++
>>>>>    1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/Android.mk b/Android.mk
>>>>> index f2c78bc1..f832b24e 100644
>>>>> --- a/Android.mk
>>>>> +++ b/Android.mk
>>>>> @@ -61,6 +61,9 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
>>>>>           $(LOCAL_PATH) \
>>>>>           $(LOCAL_PATH)/include/drm
>>>>>
>>>>> +LOCAL_SHARED_LIBRARIES := \
>>>>> +       liblog
>>>>> +
>>>>>    LOCAL_C_INCLUDES := \
>>>>>           $(LOCAL_PATH)/include/drm
>>>>>
>>>>> --
>>>>> 2.19.1
>>>>>
>>>> _______________________________________________
>>>> dri-devel mailing list
>>>> dri-devel@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel