From: "Tapani Pälli" <tapani.palli@intel.com>
To: Mauro Rossi <issor.oruam@gmail.com>, dri-devel@lists.freedesktop.org
Cc: robert.foss@collabora.com
Subject: Re: [PATCH] android: libdrm_platform: add liblog shared dependency
Date: Mon, 18 Mar 2019 13:40:50 +0200 [thread overview]
Message-ID: <5f42bc83-b36e-473d-e5d3-b79b04fb5eba@intel.com> (raw)
In-Reply-To: <20190317205012.8419-1-issor.oruam@gmail.com>
It seems like there is no usage of __android_log_vprint in upstream
libdrm. Perhaps this was against libdrm with some android specific
changes on top?
On 3/17/19 10:50 PM, Mauro Rossi wrote:
> Fixes the following building error:
>
> FAILED: $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates/LINKED/libdrm_platform.so
> ...
> external/libdrm/xf86drm.c:146: error: undefined reference to '__android_log_vprint'
> clang.real: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
> ---
> Android.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Android.mk b/Android.mk
> index f2c78bc1..f832b24e 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -61,6 +61,9 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
> $(LOCAL_PATH) \
> $(LOCAL_PATH)/include/drm
>
> +LOCAL_SHARED_LIBRARIES := \
> + liblog
> +
> LOCAL_C_INCLUDES := \
> $(LOCAL_PATH)/include/drm
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-03-18 11:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 20:50 [PATCH] android: libdrm_platform: add liblog shared dependency Mauro Rossi
2019-03-17 20:54 ` Mauro Rossi
2019-03-18 8:09 ` Robert Foss
2019-03-18 8:21 ` Robert Foss
2019-03-18 8:38 ` Mauro Rossi
2019-03-18 9:58 ` Robert Foss
2019-03-18 13:11 ` Mauro Rossi
2019-03-18 13:25 ` Robert Foss
2019-03-18 13:32 ` Tapani Pälli
2019-04-17 17:49 ` Emil Velikov
2019-04-22 9:46 ` Mauro Rossi
2019-04-26 22:06 ` Mauro Rossi
2019-06-24 5:56 ` Chih-Wei Huang
2019-04-22 9:39 ` Mauro Rossi
2019-03-18 11:40 ` Tapani Pälli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f42bc83-b36e-473d-e5d3-b79b04fb5eba@intel.com \
--to=tapani.palli@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=issor.oruam@gmail.com \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox