From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: remove EBUSY handling in ttm_execbuf_util
Date: Mon, 20 Aug 2012 19:55:25 +0200 [thread overview]
Message-ID: <50327A0D.7080805@canonical.com> (raw)
In-Reply-To: <CAH3drwbPZsY+B1qZ8ijkJKfxZUUEqW0LnQ9M=Mb=XyshnhiDVA@mail.gmail.com>
Hey,
Op 20-08-12 17:15, Jerome Glisse schreef:
> On Mon, Aug 20, 2012 at 9:42 AM, Maarten Lankhorst
> <maarten.lankhorst@canonical.com> wrote:
>> How is this different from just calling with no_wait == false?
>> As far as I can tell, both paths end up with the same result..
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> NAK this seriously modify the behavior. The ttm_eu_del_from_lru_locked
> part is important. It must happen with lru lock held and without any
> dropping of this lock prior to wait for bo unreserve.
>
You're right, I missed the part where it removed those, causing the later
patch to be wrong too. However I still think the code can be made more
readable. Wouldn't it be better if it used the unlocked variants instead?
It would save a lot of extra list traversals, and you could drop
removed, reserved and put_count from ttm_validate_buffer.
~Maarten
next prev parent reply other threads:[~2012-08-20 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 13:42 [PATCH] drm/ttm: remove EBUSY handling in ttm_execbuf_util Maarten Lankhorst
2012-08-20 15:15 ` Jerome Glisse
2012-08-20 17:55 ` Maarten Lankhorst [this message]
2012-08-20 18:04 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50327A0D.7080805@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox