From: Thomas Hellstrom <thellstrom@vmware.com>
To: Maarten Lankhorst <m.b.lankhorst@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] drm/ttm: cope with reserved buffers on swap list in ttm_bo_swapout, v2
Date: Wed, 28 Nov 2012 15:27:18 +0100 [thread overview]
Message-ID: <50B61F46.7060707@vmware.com> (raw)
In-Reply-To: <1354101944-10455-4-git-send-email-maarten.lankhorst@canonical.com>
On 11/28/2012 12:25 PM, Maarten Lankhorst wrote:
> Replace the while loop with a simple for each loop, and only run the
> delayed destroy cleanup if we can reserve the buffer first.
>
> No race occurs, since lru lock is never dropped any more. An empty list
> and a list full of unreservable buffers both cause -EBUSY to be returned,
> which is identical to the previous situation.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 44 ++++++++++++++------------------------------
> 1 file changed, 14 insertions(+), 30 deletions(-)
>
For patch 4-6
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
next prev parent reply other threads:[~2012-11-28 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 11:25 [PATCH 1/6] drm/ttm: change fence_lock to inner lock Maarten Lankhorst
2012-11-28 11:25 ` [PATCH 2/6] drm/radeon: allow move_notify to be called without reservation Maarten Lankhorst
2012-11-28 11:25 ` [PATCH 3/6] drm/ttm: call ttm_bo_cleanup_refs with reservation and lru lock held Maarten Lankhorst
2012-11-28 11:54 ` Thomas Hellstrom
2012-11-28 12:15 ` Maarten Lankhorst
2012-11-28 13:21 ` Thomas Hellstrom
2012-11-28 13:55 ` Maarten Lankhorst
2012-11-28 14:23 ` Thomas Hellstrom
2012-11-28 14:46 ` Maarten Lankhorst
2012-11-28 15:10 ` Thomas Hellstrom
2012-11-28 18:32 ` Maarten Lankhorst
2012-11-28 19:21 ` Thomas Hellstrom
2012-11-28 22:26 ` Maarten Lankhorst
2012-11-29 9:42 ` Thomas Hellstrom
2012-11-29 11:36 ` [PATCH 3/6] drm/ttm: call ttm_bo_cleanup_refs with reservation and lru lock held, v3 Maarten Lankhorst
2012-11-29 20:43 ` Thomas Hellstrom
2012-11-28 12:28 ` [PATCH 3/6] drm/ttm: call ttm_bo_cleanup_refs with reservation and lru lock held Maarten Lankhorst
2012-11-28 11:25 ` [PATCH 4/6] drm/ttm: cope with reserved buffers on swap list in ttm_bo_swapout, v2 Maarten Lankhorst
2012-11-28 14:27 ` Thomas Hellstrom [this message]
2012-11-28 11:25 ` [PATCH 5/6] drm/ttm: cope with reserved buffers on lru list in ttm_mem_evict_first, v2 Maarten Lankhorst
2012-11-28 11:25 ` [PATCH 6/6] drm/ttm: remove no_wait_reserve, v3 Maarten Lankhorst
2012-11-28 11:40 ` [PATCH 1/6] drm/ttm: change fence_lock to inner lock Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B61F46.7060707@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=m.b.lankhorst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox