Re: [PATCH] man: Fix typo and use $() for make expressions

[Mark Zhang <nvmarkzhang@gmail.com>]

Hi David:

Sorry for jumping in. I pulled the ToT libdrm and it seems the manpages
will not be built("make html" does nothing), any suggestions?

P.S: I've installed xsltproc.

Mark
On 01/19/2013 12:01 AM, David Herrmann wrote:
> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann
> <dh.herrmann@googlemail.com> wrote:
>> Hi Thierry
>>
>> On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding
>> <thierry.reding@avionic-design.de> wrote:
>>> Due to the typo, none of the .xml files would end up in the release
>>> tarball and cause make distcheck as well as builds from the tarball to
>>> fail.
>>>
>>> Using $() isn't strictly necessary but other variables and expressions
>>> use that variant already so it makes the usage consistent.
>>
>> That's weird. "make distcheck" should not be able to build the
>> manpages if the XML files are not available. Also ${} is pretty
>> standard in makefiles, isn't it? I wonder what the problem here is. At
>> least distcheck runs fine on my machine.
> 
> Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why
> distcheck works here. But the patch looks fine. Thanks!
> 
>> Regards
>> David
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>