Re: [PATCH] man: Fix typo and use $() for make expressions

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Fri, 25 Jan 2013 16:54:11 +0100
David Herrmann <dh.herrmann@googlemail.com> wrote:

> Hi Jesse
> 
> On Fri, Jan 18, 2013 at 5:54 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Fri, 18 Jan 2013 17:01:59 +0100
> > David Herrmann <dh.herrmann@googlemail.com> wrote:
> >
> >> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann
> >> <dh.herrmann@googlemail.com> wrote:
> >> > Hi Thierry
> >> >
> >> > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding
> >> > <thierry.reding@avionic-design.de> wrote:
> >> >> Due to the typo, none of the .xml files would end up in the release
> >> >> tarball and cause make distcheck as well as builds from the tarball to
> >> >> fail.
> >> >>
> >> >> Using $() isn't strictly necessary but other variables and expressions
> >> >> use that variant already so it makes the usage consistent.
> >> >
> >> > That's weird. "make distcheck" should not be able to build the
> >> > manpages if the XML files are not available. Also ${} is pretty
> >> > standard in makefiles, isn't it? I wonder what the problem here is. At
> >> > least distcheck runs fine on my machine.
> >>
> >> Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why
> >> distcheck works here. But the patch looks fine. Thanks!
> >
> > Works here too.  Pushed with David's reviewed-by.  Thanks Thierry.
> 
> Did you forget to push this patch? I cannot see it in upstream fdo
> libdrm repository. Or maybe I am just looking at the wrong place.

Yeah failed to push, sorry.  Should be there now.

-- 
Jesse Barnes, Intel Open Source Technology Center