From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID
Date: Mon, 22 Apr 2013 18:07:48 +0200 [thread overview]
Message-ID: <51756054.8040705@vodafone.de> (raw)
In-Reply-To: <CADnq5_OzwdZ-Stw4RsYdQyYe9wfozT3GpF3n+vU69HYm6cHS2Q@mail.gmail.com>
Am 21.04.2013 23:53, schrieb Alex Deucher:
> On Fri, Apr 19, 2013 at 1:01 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> Some devices (ATI/AMD cards) don't support passing ELD struct to the
>> hardware but just require filling specific registers and then the
>> hardware/firmware does the rest. In such cases we need to read the info
>> from SAD blocks and put them in the correct registers.
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Thanks both patches applied. I added a comment about needing to kfree
> the returned pointer as per Christian's comment.
Found one more minor nitpick in this patch:
> + if (cea_db_tag(db) == AUDIO_BLOCK) {
> + dbl = cea_db_payload_len(db);
> + int j;
> +
That's code after declaration and so complained on by the compiler.
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-04-22 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:01 [PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID Rafał Miłecki
2013-04-19 17:01 ` [PATCH 2/2] drm/radeon/evergreen: set SAD registers Rafał Miłecki
2013-04-19 17:08 ` [PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID Christian König
2013-04-21 21:53 ` Alex Deucher
2013-04-22 16:07 ` Christian König [this message]
2013-04-22 16:12 ` Rafał Miłecki
2013-04-22 16:16 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51756054.8040705@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox