From: Kenneth Graunke <kenneth@whitecape.org>
To: Keith Packard <keithp@keithp.com>,
Emil Velikov <emil.l.velikov@gmail.com>,
mesa-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Don't use libudev for glx/dri3
Date: Sun, 17 Nov 2013 20:08:39 -0800 [thread overview]
Message-ID: <528992C7.9030507@whitecape.org> (raw)
In-Reply-To: <86vbzq5t0c.fsf@miki.keithp.com>
On 11/17/2013 06:43 PM, Keith Packard wrote:
> Emil Velikov <emil.l.velikov@gmail.com> writes:
>
>> On 18/11/13 01:08, Keith Packard wrote:
>>> libudev doesn't have a stable API/ABI, and if the application wants to use one
>>> version, we'd best not load another into libGL.
>>>
>>> Signed-off-by: Keith Packard <keithp@keithp.com>
>>> ---
>>>
>> Hi Keith,
>>
>> Firstly, I would like to apologise for the rather daft questions.
>>
>> With that said, looking through your patch I've noticed that (most of)
>> your int functions are returning 0 or failure and 1 on success. Were
>> those functions meant to return boolean/bool?
>
> Sure, but I was too lazy to figure out which kind of bool belongs in
> that part of mesa...
For non-API facing stuff, you can just use stdbool.h's bool/true/false.
--Ken
next prev parent reply other threads:[~2013-11-18 4:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 0:55 [PATCH] Don't use libudev for glx/dri3 Keith Packard
2013-11-18 1:08 ` Keith Packard
2013-11-18 1:31 ` Emil Velikov
2013-11-18 2:43 ` Keith Packard
2013-11-18 4:08 ` Kenneth Graunke [this message]
2013-11-18 6:03 ` Keith Packard
2013-11-18 21:59 ` Ian Romanick
2013-11-18 20:58 ` Emil Velikov
2013-11-19 6:46 ` Keith Packard
2013-12-14 2:33 ` Kenneth Graunke
2013-12-14 10:37 ` [Mesa-dev] " Daniel Vetter
2013-12-16 19:19 ` Eric Anholt
2013-12-16 19:57 ` [Mesa-dev] " Daniel Vetter
2013-11-19 18:41 ` Eric Anholt
2013-11-19 19:41 ` Keith Packard
2013-11-19 20:19 ` [Mesa-dev] " Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528992C7.9030507@whitecape.org \
--to=kenneth@whitecape.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=keithp@keithp.com \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox