dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel@ffwll.ch>, Kenneth Graunke <kenneth@whitecape.org>
Cc: Mesa Dev <mesa-dev@lists.freedesktop.org>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] Don't use libudev for glx/dri3
Date: Mon, 16 Dec 2013 11:19:56 -0800	[thread overview]
Message-ID: <87txe8r4bn.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <CAKMK7uEUw1uk=NsKW1zBcuCdioXmB-Q=2iquED2M0P4LGJVDag@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1461 bytes --]

Daniel Vetter <daniel@ffwll.ch> writes:

> On Sat, Dec 14, 2013 at 3:33 AM, Kenneth Graunke <kenneth@whitecape.org> wrote:
>> On 11/18/2013 12:58 PM, Emil Velikov wrote:
>>> On 18/11/13 01:08, Keith Packard wrote:
>>>> libudev doesn't have a stable API/ABI, and if the application wants to use one
>>>> version, we'd best not load another into libGL.
>>>>
>>>> Signed-off-by: Keith Packard <keithp@keithp.com>
>>>> ---
>>>>
>>> Hi Keith,
>>>
>>> Did you had the chance to look at src/gallium/targets/egl-static/egl.c?
>>> It has a different implementation of drm_fd_get_pci_id, whenever udev is
>>> not available.
>>>
>>> AFAICS it goes back to the kernel via the relevant ioctl to retrieve the
>>> deviceid/chipid. Currently all but nouveau provide such information. I'm
>>> thinking that this approach might be more reasonable for those concerned
>>> with portability of the udev bits (think on *BSD).
>>>
>>> I'm not nitpicking, just thought you might find this interesting.
>>>
>>> Cheers,
>>> Emil
>>
>> Possibly.  But looking at that code, it either:
>> 1. Uses libudev
>> 2. On Android only...strcmps the driver string to guess the family and
>> then uses kernel ioctls...
>> 3. Fails.
>>
>> The Android only nature makes me a bit wary.
>
> The string mapping of the kernel driver name to a dri.so is what I
> kinda expected to be used as the generic thing

[snip]

There is more than one userspace driver per kernel driver.  (i915 vs
i965, for example)

[-- Attachment #1.2: Type: application/pgp-signature, Size: 835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

  reply	other threads:[~2013-12-16 19:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18  0:55 [PATCH] Don't use libudev for glx/dri3 Keith Packard
2013-11-18  1:08 ` Keith Packard
2013-11-18  1:31   ` Emil Velikov
2013-11-18  2:43     ` Keith Packard
2013-11-18  4:08       ` Kenneth Graunke
2013-11-18  6:03         ` Keith Packard
2013-11-18 21:59       ` Ian Romanick
2013-11-18 20:58   ` Emil Velikov
2013-11-19  6:46     ` Keith Packard
2013-12-14  2:33     ` Kenneth Graunke
2013-12-14 10:37       ` [Mesa-dev] " Daniel Vetter
2013-12-16 19:19         ` Eric Anholt [this message]
2013-12-16 19:57           ` Daniel Vetter
2013-11-19 18:41   ` Eric Anholt
2013-11-19 19:41     ` Keith Packard
2013-11-19 20:19       ` [Mesa-dev] " Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txe8r4bn.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=kenneth@whitecape.org \
    --cc=mesa-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox