Re: [i915] BUG: Bad page state in process Xorg

Re: [i915] BUG: Bad page state in process Xorg

[Dave Airlie]

> Hi,

cc'ing mailing list,

Daniel any ideas?

Dave.

> I reported this bug a few days ago, but nobody did respond to my bug
> report:
> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/00058.html
> 
> Every time I restart the X server I will run into this bug with 3.12.0.
> 
> Help is welcome.
> 
> [ 9913.719551] BUG: Bad page state in process Xorg  pfn:20f2bb
> [ 9913.721755] page:ffffea00083caec0 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xe
> [ 9913.733741] page flags: 0x800000000008001c(referenced|uptodate|dirty|swapbacked)
> [ 9913.741062] Modules linked in: tcp_lp fuse ipt_MASQUERADE ip6t_REJECT xt_conntrack bluetooth ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw arc4 iwldvm snd_usb_audio mac80211 snd_hda_codec_hdmi iwlwifi snd_hda_codec_realtek snd_usbmidi_lib snd_hda_intel kvm_intel asix snd_hda_codec usbnet kvm atl1c snd_hwdep mii snd_seq acer_wmi acerhdf sparse_keymap snd_pcm joydev pcspkr cfg80211 rfkill acpi_cpufreq freq_table snd_rawmidi snd_seq_device snd_page_alloc snd_timer snd wmi soundcore uinput ipv6 xts gf128mul udl syscopyarea sysfillrect sysimgblt drm_usb usb_storage
> [ 9913.741125] CPU: 0 PID: 723 Comm: Xorg Tainted: G    B        3.12.0 #2
> [ 9913.741128] Hardware name: Acer Aspire 1810T/JM11-MS, BIOS v1.3310 03/25/2010
> [ 9913.741130]  0000000000000000 ffff880213127cc0 ffffffff8154dc8b ffff880213127cd8
> [ 9913.741135]  ffffffff8154b6e7 ffffea00083caec0 ffff880213127d10 ffffffff810c6955
> [ 9913.741139]  ffffea00083caec0 800000000008001c 0000000000000000 ffff880234080000
> [ 9913.741143] Call Trace:
> [ 9913.741151]  [<ffffffff8154dc8b>] dump_stack+0x19/0x1b
> [ 9913.741155]  [<ffffffff8154b6e7>] bad_page+0xc9/0xe2
> [ 9913.741160]  [<ffffffff810c6955>] free_pages_prepare+0xd5/0xe0
> [ 9913.741165]  [<ffffffff810c725d>] free_hot_cold_page+0x1d/0x120
> [ 9913.741169]  [<ffffffff810cbe9e>] __put_single_page+0x1e/0x30
> [ 9913.741172]  [<ffffffff810cc045>] put_page+0x25/0x40
> [ 9913.741178]  [<ffffffff81346a73>] i915_gem_object_put_pages_gtt+0xc3/0x1a0
> [ 9913.741183]  [<ffffffff81348378>] i915_gem_object_put_pages+0x78/0xd0
> [ 9913.741187]  [<ffffffff8134a167>] i915_gem_free_object+0xe7/0x220
> [ 9913.741192]  [<ffffffff81318a75>] drm_gem_object_free+0x25/0x30
> [ 9913.741196]  [<ffffffff8132e5db>] drm_gem_dmabuf_release+0x4b/0x70
> [ 9913.741201]  [<ffffffff813ae0b7>] dma_buf_release+0x27/0x90
> [ 9913.741205]  [<ffffffff8110deab>] __fput+0xcb/0x240
> [ 9913.741209]  [<ffffffff8110e059>] ____fput+0x9/0x10
> [ 9913.741214]  [<ffffffff81052b5c>] task_work_run+0x9c/0xc0
> [ 9913.741219]  [<ffffffff8103a365>] do_exit+0x6d5/0x9d0
> [ 9913.741223]  [<ffffffff81551063>] ? __schedule+0x243/0x5e0
> [ 9913.741227]  [<ffffffff81052b44>] ? task_work_run+0x84/0xc0
> [ 9913.741232]  [<ffffffff8103b4d5>] do_group_exit+0x35/0x90
> [ 9913.741236]  [<ffffffff8103b53f>] SyS_exit_group+0xf/0x10
> [ 9913.741241]  [<ffffffff81558960>] system_call_fastpath+0x16/0x1b
> [ 9913.741246] BUG: Bad page state in process Xorg  pfn:20f2bc
> [ 9913.749565] page:ffffea00083caf00 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xf
> 
> with kind regards
> thomas
> 
> 
> 
> 

Re: [i915] BUG: Bad page state in process Xorg

[Daniel Vetter]

On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>> Hi,
>
> cc'ing mailing list,
>
> Daniel any ideas?

Nope, not really :( And no ideas how to triage this further - if it
takes 9 days to hit it eventually we'll have a real hard time. Or does
this happen even after just a short X run?

Also is this a regression, i.e. please test a few older kernels, too.
-Daniel

>
> Dave.
>
>> I reported this bug a few days ago, but nobody did respond to my bug
>> report:
>> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/00058.html
>>
>> Every time I restart the X server I will run into this bug with 3.12.0.
>>
>> Help is welcome.
>>
>> [ 9913.719551] BUG: Bad page state in process Xorg  pfn:20f2bb
>> [ 9913.721755] page:ffffea00083caec0 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xe
>> [ 9913.733741] page flags: 0x800000000008001c(referenced|uptodate|dirty|swapbacked)
>> [ 9913.741062] Modules linked in: tcp_lp fuse ipt_MASQUERADE ip6t_REJECT xt_conntrack bluetooth ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw arc4 iwldvm snd_usb_audio mac80211 snd_hda_codec_hdmi iwlwifi snd_hda_codec_realtek snd_usbmidi_lib snd_hda_intel kvm_intel asix snd_hda_codec usbnet kvm atl1c snd_hwdep mii snd_seq acer_wmi acerhdf sparse_keymap snd_pcm joydev pcspkr cfg80211 rfkill acpi_cpufreq freq_table snd_rawmidi snd_seq_device snd_page_alloc snd_timer snd wmi soundcore uinput ipv6 xts gf128mul udl syscopyarea sysfillrect sysimgblt drm_usb usb_storage
>> [ 9913.741125] CPU: 0 PID: 723 Comm: Xorg Tainted: G    B        3.12.0 #2
>> [ 9913.741128] Hardware name: Acer Aspire 1810T/JM11-MS, BIOS v1.3310 03/25/2010
>> [ 9913.741130]  0000000000000000 ffff880213127cc0 ffffffff8154dc8b ffff880213127cd8
>> [ 9913.741135]  ffffffff8154b6e7 ffffea00083caec0 ffff880213127d10 ffffffff810c6955
>> [ 9913.741139]  ffffea00083caec0 800000000008001c 0000000000000000 ffff880234080000
>> [ 9913.741143] Call Trace:
>> [ 9913.741151]  [<ffffffff8154dc8b>] dump_stack+0x19/0x1b
>> [ 9913.741155]  [<ffffffff8154b6e7>] bad_page+0xc9/0xe2
>> [ 9913.741160]  [<ffffffff810c6955>] free_pages_prepare+0xd5/0xe0
>> [ 9913.741165]  [<ffffffff810c725d>] free_hot_cold_page+0x1d/0x120
>> [ 9913.741169]  [<ffffffff810cbe9e>] __put_single_page+0x1e/0x30
>> [ 9913.741172]  [<ffffffff810cc045>] put_page+0x25/0x40
>> [ 9913.741178]  [<ffffffff81346a73>] i915_gem_object_put_pages_gtt+0xc3/0x1a0
>> [ 9913.741183]  [<ffffffff81348378>] i915_gem_object_put_pages+0x78/0xd0
>> [ 9913.741187]  [<ffffffff8134a167>] i915_gem_free_object+0xe7/0x220
>> [ 9913.741192]  [<ffffffff81318a75>] drm_gem_object_free+0x25/0x30
>> [ 9913.741196]  [<ffffffff8132e5db>] drm_gem_dmabuf_release+0x4b/0x70
>> [ 9913.741201]  [<ffffffff813ae0b7>] dma_buf_release+0x27/0x90
>> [ 9913.741205]  [<ffffffff8110deab>] __fput+0xcb/0x240
>> [ 9913.741209]  [<ffffffff8110e059>] ____fput+0x9/0x10
>> [ 9913.741214]  [<ffffffff81052b5c>] task_work_run+0x9c/0xc0
>> [ 9913.741219]  [<ffffffff8103a365>] do_exit+0x6d5/0x9d0
>> [ 9913.741223]  [<ffffffff81551063>] ? __schedule+0x243/0x5e0
>> [ 9913.741227]  [<ffffffff81052b44>] ? task_work_run+0x84/0xc0
>> [ 9913.741232]  [<ffffffff8103b4d5>] do_group_exit+0x35/0x90
>> [ 9913.741236]  [<ffffffff8103b53f>] SyS_exit_group+0xf/0x10
>> [ 9913.741241]  [<ffffffff81558960>] system_call_fastpath+0x16/0x1b
>> [ 9913.741246] BUG: Bad page state in process Xorg  pfn:20f2bc
>> [ 9913.749565] page:ffffea00083caf00 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xf
>>
>> with kind regards
>> thomas
>>
>>
>>
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [i915] BUG: Bad page state in process Xorg

[Thomas Meyer]

> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
> 
> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>>> Hi,
>> 
>> cc'ing mailing list,
>> 
>> Daniel any ideas?
> 
> Nope, not really :( And no ideas how to triage this further - if it
> takes 9 days to hit it eventually we'll have a real hard time. Or does
> this happen even after just a short X run?

Seems to happen every time while stopping the x server. Also after a short run time.

The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.

I did turn on config-debug-pagealloc but this didn't show any wrongness.

> 
> Also is this a regression, i.e. please test a few older kernels, too.
> -Daniel
> 
>> 
>> Dave.
>> 
>>> I reported this bug a few days ago, but nobody did respond to my bug
>>> report:
>>> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/00058.html
>>> 
>>> Every time I restart the X server I will run into this bug with 3.12.0.
>>> 
>>> Help is welcome.
>>> 
>>> [ 9913.719551] BUG: Bad page state in process Xorg  pfn:20f2bb
>>> [ 9913.721755] page:ffffea00083caec0 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xe
>>> [ 9913.733741] page flags: 0x800000000008001c(referenced|uptodate|dirty|swapbacked)
>>> [ 9913.741062] Modules linked in: tcp_lp fuse ipt_MASQUERADE ip6t_REJECT xt_conntrack bluetooth ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw arc4 iwldvm snd_usb_audio mac80211 snd_hda_codec_hdmi iwlwifi snd_hda_codec_realtek snd_usbmidi_lib snd_hda_intel kvm_intel asix snd_hda_codec usbnet kvm atl1c snd_hwdep mii snd_seq acer_wmi acerhdf sparse_keymap snd_pcm joydev pcspkr cfg80211 rfkill acpi_cpufreq freq_table snd_rawmidi snd_seq_device snd_page_alloc snd_timer snd wmi soundcore uinput ipv6 xts gf128mul udl syscopyarea sysfillrect sysimgblt drm_usb usb_storage
>>> [ 9913.741125] CPU: 0 PID: 723 Comm: Xorg Tainted: G    B        3.12.0 #2
>>> [ 9913.741128] Hardware name: Acer Aspire 1810T/JM11-MS, BIOS v1.3310 03/25/2010
>>> [ 9913.741130]  0000000000000000 ffff880213127cc0 ffffffff8154dc8b ffff880213127cd8
>>> [ 9913.741135]  ffffffff8154b6e7 ffffea00083caec0 ffff880213127d10 ffffffff810c6955
>>> [ 9913.741139]  ffffea00083caec0 800000000008001c 0000000000000000 ffff880234080000
>>> [ 9913.741143] Call Trace:
>>> [ 9913.741151]  [<ffffffff8154dc8b>] dump_stack+0x19/0x1b
>>> [ 9913.741155]  [<ffffffff8154b6e7>] bad_page+0xc9/0xe2
>>> [ 9913.741160]  [<ffffffff810c6955>] free_pages_prepare+0xd5/0xe0
>>> [ 9913.741165]  [<ffffffff810c725d>] free_hot_cold_page+0x1d/0x120
>>> [ 9913.741169]  [<ffffffff810cbe9e>] __put_single_page+0x1e/0x30
>>> [ 9913.741172]  [<ffffffff810cc045>] put_page+0x25/0x40
>>> [ 9913.741178]  [<ffffffff81346a73>] i915_gem_object_put_pages_gtt+0xc3/0x1a0
>>> [ 9913.741183]  [<ffffffff81348378>] i915_gem_object_put_pages+0x78/0xd0
>>> [ 9913.741187]  [<ffffffff8134a167>] i915_gem_free_object+0xe7/0x220
>>> [ 9913.741192]  [<ffffffff81318a75>] drm_gem_object_free+0x25/0x30
>>> [ 9913.741196]  [<ffffffff8132e5db>] drm_gem_dmabuf_release+0x4b/0x70
>>> [ 9913.741201]  [<ffffffff813ae0b7>] dma_buf_release+0x27/0x90
>>> [ 9913.741205]  [<ffffffff8110deab>] __fput+0xcb/0x240
>>> [ 9913.741209]  [<ffffffff8110e059>] ____fput+0x9/0x10
>>> [ 9913.741214]  [<ffffffff81052b5c>] task_work_run+0x9c/0xc0
>>> [ 9913.741219]  [<ffffffff8103a365>] do_exit+0x6d5/0x9d0
>>> [ 9913.741223]  [<ffffffff81551063>] ? __schedule+0x243/0x5e0
>>> [ 9913.741227]  [<ffffffff81052b44>] ? task_work_run+0x84/0xc0
>>> [ 9913.741232]  [<ffffffff8103b4d5>] do_group_exit+0x35/0x90
>>> [ 9913.741236]  [<ffffffff8103b53f>] SyS_exit_group+0xf/0x10
>>> [ 9913.741241]  [<ffffffff81558960>] system_call_fastpath+0x16/0x1b
>>> [ 9913.741246] BUG: Bad page state in process Xorg  pfn:20f2bc
>>> [ 9913.749565] page:ffffea00083caf00 count:0 mapcount:0 mapping:ffff8802357975f8 index:0xf
>>> 
>>> with kind regards
>>> thomas
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [i915] BUG: Bad page state in process Xorg

[Daniel Vetter]

On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
>>
>> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>>>> Hi,
>>>
>>> cc'ing mailing list,
>>>
>>> Daniel any ideas?
>>
>> Nope, not really :( And no ideas how to triage this further - if it
>> takes 9 days to hit it eventually we'll have a real hard time. Or does
>> this happen even after just a short X run?
>
> Seems to happen every time while stopping the x server. Also after a short run time.
>
> The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
>
> I did turn on config-debug-pagealloc but this didn't show any wrongness.

In that case I think the bisect is the fastest way to insight - atm
I'm really at loss what could be wrong here.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [i915] BUG: Bad page state in process Xorg

[Thomas Hellstrom]

On 11/22/2013 05:18 PM, Daniel Vetter wrote:
> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>>> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
>>>
>>> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>>>>> Hi,
>>>> cc'ing mailing list,
>>>>
>>>> Daniel any ideas?
>>> Nope, not really :( And no ideas how to triage this further - if it
>>> takes 9 days to hit it eventually we'll have a real hard time. Or does
>>> this happen even after just a short X run?
>> Seems to happen every time while stopping the x server. Also after a short run time.
>>
>> The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
>>
>> I did turn on config-debug-pagealloc but this didn't show any wrongness.
> In that case I think the bisect is the fastest way to insight - atm
> I'm really at loss what could be wrong here.

 From the error messages it looks like whatever's responsible for 
clearing page->mapping doesn't do it for these pages,
(shmem code?).

/Thomas

> -Daniel

Re: [i915] BUG: Bad page state in process Xorg

[Chris Wilson]

On Wed, Nov 20, 2013 at 09:55:28PM +0100, Thomas Meyer wrote:
> Hi,
> 
> I reported this bug a few days ago, but nobody did respond to my bug
> report:
> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/00058.html
> 
> Every time I restart the X server I will run into this bug with 3.12.0.

I think whilst we scratch our heads wondering about what could cause
corruption in our struct page, we would welcome a bisection. If it dies
during X startup, it would seems like a bisection would progress
quickly. Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [i915] BUG: Bad page state in process Xorg

[Thomas Meyer]

> Am 22.11.2013 um 11:55 schrieb Chris Wilson <chris@chris-wilson.co.uk>:
> 
>> On Wed, Nov 20, 2013 at 09:55:28PM +0100, Thomas Meyer wrote:
>> Hi,
>> 
>> I reported this bug a few days ago, but nobody did respond to my bug
>> report:
>> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/00058.html
>> 
>> Every time I restart the X server I will run into this bug with 3.12.0.
> 
> I think whilst we scratch our heads wondering about what could cause
> corruption in our struct page, we would welcome a bisection. If it dies
> during X startup, it would seems like a bisection would progress
> quickly. Thanks,

No, but on every(?) shutdown of the Xorg server. So I'll try to bisect this. Hopefully I'll find some time this weekend.

> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

Re: [i915] BUG: Bad page state in process Xorg

[thomas]

Hi,

It turns out that this seems to be a bug in udl DRM driver.

I bisected the problem to this patch:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641

With kind regards
Thomas

Am 22.11.2013 17:18 schrieb Daniel Vetter <daniel@ffwll.ch>:
>
> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote: 
> >> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>: 
> >> 
> >> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote: 
> >>>> Hi, 
> >>> 
> >>> cc'ing mailing list, 
> >>> 
> >>> Daniel any ideas? 
> >> 
> >> Nope, not really :( And no ideas how to triage this further - if it 
> >> takes 9 days to hit it eventually we'll have a real hard time. Or does 
> >> this happen even after just a short X run? 
> > 
> > Seems to happen every time while stopping the x server. Also after a short run time. 
> > 
> > The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel. 
> > 
> > I did turn on config-debug-pagealloc but this didn't show any wrongness. 
>
> In that case I think the bisect is the fastest way to insight - atm 
> I'm really at loss what could be wrong here. 
> -Daniel 
> -- 
> Daniel Vetter 
> Software Engineer, Intel Corporation 
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch 

Re: [i915] BUG: Bad page state in process Xorg

[Rob Clark]

oh, hmm.. are you importing buffers from i915?  It looks like this part:

- if (obj->base.import_attach) {
- drm_free_large(obj->pages);
- obj->pages = NULL;
- return;
- }

should not have been removed from udl_gem_put_pages()..

BR,
-R

On Mon, Nov 25, 2013 at 8:17 AM,  <thomas@m3y3r.de> wrote:
> Hi,
>
> It turns out that this seems to be a bug in udl DRM driver.
>
> I bisected the problem to this patch:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641
>
> With kind regards
> Thomas
>
> Am 22.11.2013 17:18 schrieb Daniel Vetter <daniel@ffwll.ch>:
>>
>> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> >> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
>> >>
>> >> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>> >>>> Hi,
>> >>>
>> >>> cc'ing mailing list,
>> >>>
>> >>> Daniel any ideas?
>> >>
>> >> Nope, not really :( And no ideas how to triage this further - if it
>> >> takes 9 days to hit it eventually we'll have a real hard time. Or does
>> >> this happen even after just a short X run?
>> >
>> > Seems to happen every time while stopping the x server. Also after a short run time.
>> >
>> > The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
>> >
>> > I did turn on config-debug-pagealloc but this didn't show any wrongness.
>>
>> In that case I think the bisect is the fastest way to insight - atm
>> I'm really at loss what could be wrong here.
>> -Daniel
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [i915] BUG: Bad page state in process Xorg

[Thomas Meyer]

Am Montag, den 25.11.2013, 08:23 -0500 schrieb Rob Clark:
> oh, hmm.. are you importing buffers from i915?  It looks like this part:

My computer has an i915 graphic card and I use an USB docking station,
that has an unconnected UDL device inside.

> 
> - if (obj->base.import_attach) {
> - drm_free_large(obj->pages);
> - obj->pages = NULL;
> - return;
> - }
> 
> should not have been removed from udl_gem_put_pages()..

Do you want me to test this? Can this please be fixed in the stable
tree?
I removed the UDL driver from my config for now, as I don't use it.
      * 
best regards
thomas

> 
> BR,
> -R
> 
> On Mon, Nov 25, 2013 at 8:17 AM,  <thomas@m3y3r.de> wrote:
> > Hi,
> >
> > It turns out that this seems to be a bug in udl DRM driver.
> >
> > I bisected the problem to this patch:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641
> >
> > With kind regards
> > Thomas
> >
> > Am 22.11.2013 17:18 schrieb Daniel Vetter <daniel@ffwll.ch>:
> >>
> >> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> >> >> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
> >> >>
> >> >> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
> >> >>>> Hi,
> >> >>>
> >> >>> cc'ing mailing list,
> >> >>>
> >> >>> Daniel any ideas?
> >> >>
> >> >> Nope, not really :( And no ideas how to triage this further - if it
> >> >> takes 9 days to hit it eventually we'll have a real hard time. Or does
> >> >> this happen even after just a short X run?
> >> >
> >> > Seems to happen every time while stopping the x server. Also after a short run time.
> >> >
> >> > The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
> >> >
> >> > I did turn on config-debug-pagealloc but this didn't show any wrongness.
> >>
> >> In that case I think the bisect is the fastest way to insight - atm
> >> I'm really at loss what could be wrong here.
> >> -Daniel
> >> --
> >> Daniel Vetter
> >> Software Engineer, Intel Corporation
> >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [i915] BUG: Bad page state in process Xorg

[Rob Clark]

On Sat, Nov 30, 2013 at 3:33 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
> Am Montag, den 25.11.2013, 08:23 -0500 schrieb Rob Clark:
>> oh, hmm.. are you importing buffers from i915?  It looks like this part:
>
> My computer has an i915 graphic card and I use an USB docking station,
> that has an unconnected UDL device inside.
>
>>
>> - if (obj->base.import_attach) {
>> - drm_free_large(obj->pages);
>> - obj->pages = NULL;
>> - return;
>> - }
>>
>> should not have been removed from udl_gem_put_pages()..
>
> Do you want me to test this? Can this please be fixed in the stable
> tree?
> I removed the UDL driver from my config for now, as I don't use it.

It would be nice if you could test that (I can send you a patch if you
prefer)..  I don't actually have any UDL device to confirm.  If this
fixes the problem, send the patch to stable as well should not be a
problem.

BR,
-R


>       *
> best regards
> thomas
>
>>
>> BR,
>> -R
>>
>> On Mon, Nov 25, 2013 at 8:17 AM,  <thomas@m3y3r.de> wrote:
>> > Hi,
>> >
>> > It turns out that this seems to be a bug in udl DRM driver.
>> >
>> > I bisected the problem to this patch:
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641
>> >
>> > With kind regards
>> > Thomas
>> >
>> > Am 22.11.2013 17:18 schrieb Daniel Vetter <daniel@ffwll.ch>:
>> >>
>> >> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> >> >> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
>> >> >>
>> >> >> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
>> >> >>>> Hi,
>> >> >>>
>> >> >>> cc'ing mailing list,
>> >> >>>
>> >> >>> Daniel any ideas?
>> >> >>
>> >> >> Nope, not really :( And no ideas how to triage this further - if it
>> >> >> takes 9 days to hit it eventually we'll have a real hard time. Or does
>> >> >> this happen even after just a short X run?
>> >> >
>> >> > Seems to happen every time while stopping the x server. Also after a short run time.
>> >> >
>> >> > The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
>> >> >
>> >> > I did turn on config-debug-pagealloc but this didn't show any wrongness.
>> >>
>> >> In that case I think the bisect is the fastest way to insight - atm
>> >> I'm really at loss what could be wrong here.
>> >> -Daniel
>> >> --
>> >> Daniel Vetter
>> >> Software Engineer, Intel Corporation
>> >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>
>
>

Re: [i915] BUG: Bad page state in process Xorg

[Thomas Meyer]

Am Samstag, den 30.11.2013, 08:55 -0500 schrieb Rob Clark:
> On Sat, Nov 30, 2013 at 3:33 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
> > Am Montag, den 25.11.2013, 08:23 -0500 schrieb Rob Clark:
> >> oh, hmm.. are you importing buffers from i915?  It looks like this part:
> >
> > My computer has an i915 graphic card and I use an USB docking station,
> > that has an unconnected UDL device inside.
> >
> >>
> >> - if (obj->base.import_attach) {
> >> - drm_free_large(obj->pages);
> >> - obj->pages = NULL;
> >> - return;
> >> - }
> >>
> >> should not have been removed from udl_gem_put_pages()..
> >
> > Do you want me to test this? Can this please be fixed in the stable
> > tree?
> > I removed the UDL driver from my config for now, as I don't use it.
> 
> It would be nice if you could test that (I can send you a patch if you
> prefer)..  I don't actually have any UDL device to confirm.  If this
> fixes the problem, send the patch to stable as well should not be a
> problem.

I did a quick test and above code makes the bad page bug disappear.

> 
> BR,
> -R
> 
> 
> >       *
> > best regards
> > thomas
> >
> >>
> >> BR,
> >> -R
> >>
> >> On Mon, Nov 25, 2013 at 8:17 AM,  <thomas@m3y3r.de> wrote:
> >> > Hi,
> >> >
> >> > It turns out that this seems to be a bug in udl DRM driver.
> >> >
> >> > I bisected the problem to this patch:
> >> >
> >> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641
> >> >
> >> > With kind regards
> >> > Thomas
> >> >
> >> > Am 22.11.2013 17:18 schrieb Daniel Vetter <daniel@ffwll.ch>:
> >> >>
> >> >> On Fri, Nov 22, 2013 at 4:54 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> >> >> >> Am 22.11.2013 um 11:55 schrieb Daniel Vetter <daniel@ffwll.ch>:
> >> >> >>
> >> >> >> On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie <airlied@linux.ie> wrote:
> >> >> >>>> Hi,
> >> >> >>>
> >> >> >>> cc'ing mailing list,
> >> >> >>>
> >> >> >>> Daniel any ideas?
> >> >> >>
> >> >> >> Nope, not really :( And no ideas how to triage this further - if it
> >> >> >> takes 9 days to hit it eventually we'll have a real hard time. Or does
> >> >> >> this happen even after just a short X run?
> >> >> >
> >> >> > Seems to happen every time while stopping the x server. Also after a short run time.
> >> >> >
> >> >> > The current fedora 3.11 kernel doesn't show this bug. I'm using fedora 19, with a self compiled kernel.
> >> >> >
> >> >> > I did turn on config-debug-pagealloc but this didn't show any wrongness.
> >> >>
> >> >> In that case I think the bisect is the fastest way to insight - atm
> >> >> I'm really at loss what could be wrong here.
> >> >> -Daniel
> >> >> --
> >> >> Daniel Vetter
> >> >> Software Engineer, Intel Corporation
> >> >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> >
> >
> >