* [PATCH] gpu: drm: Optimize the unused variable ret
@ 2023-06-19 11:31 Li Dong
2023-06-20 13:01 ` Artur Weber
0 siblings, 1 reply; 2+ messages in thread
From: Li Dong @ 2023-06-19 11:31 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Sam Ravnborg, David Airlie,
Daniel Vetter, open list:DRM PANEL DRIVERS, open list
Cc: opensource.kernel, lidong
Use zero as the return value instead of the unused variable ret
Signed-off-by: Li Dong <lidong@vivo.com>
---
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
index 102e1fc7ee38..fec0d014fd0e 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
@@ -66,7 +66,6 @@ static void s6d7aa0_reset(struct s6d7aa0 *ctx)
static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
{
struct mipi_dsi_device *dsi = ctx->dsi;
- int ret = 0;
if (lock) {
mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5);
@@ -80,7 +79,7 @@ static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0xa5, 0xa5);
}
- return ret;
+ return 0;
}
static int s6d7aa0_on(struct s6d7aa0 *ctx)
--
2.31.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpu: drm: Optimize the unused variable ret
2023-06-19 11:31 [PATCH] gpu: drm: Optimize the unused variable ret Li Dong
@ 2023-06-20 13:01 ` Artur Weber
0 siblings, 0 replies; 2+ messages in thread
From: Artur Weber @ 2023-06-20 13:01 UTC (permalink / raw)
To: Li Dong, Neil Armstrong, Sam Ravnborg, David Airlie,
Daniel Vetter, open list:DRM PANEL DRIVERS, open list
Cc: opensource.kernel
On 19/06/2023 13:31, Li Dong wrote:
> Use zero as the return value instead of the unused variable ret
>
> Signed-off-by: Li Dong <lidong@vivo.com>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> index 102e1fc7ee38..fec0d014fd0e 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> @@ -66,7 +66,6 @@ static void s6d7aa0_reset(struct s6d7aa0 *ctx)
> static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
> {
> struct mipi_dsi_device *dsi = ctx->dsi;
> - int ret = 0;
>
> if (lock) {
> mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5);
> @@ -80,7 +79,7 @@ static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
> mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0xa5, 0xa5);
> }
>
> - return ret;
> + return 0;
> }
>
> static int s6d7aa0_on(struct s6d7aa0 *ctx)
Commit "drm/panel: s6d7aa0: remove the unneeded variable in
s6d7aa0_lock"[1] already does this.
Best regards
Artur
[1] https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c?id=c5dacfe2e6c1251276e29b4cdac771f504593523
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-20 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 11:31 [PATCH] gpu: drm: Optimize the unused variable ret Li Dong
2023-06-20 13:01 ` Artur Weber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox