* rockchip and atmel kms drivers @ 2014-09-17 1:18 Dave Airlie 2014-09-17 5:41 ` Boris BREZILLON 0 siblings, 1 reply; 6+ messages in thread From: Dave Airlie @ 2014-09-17 1:18 UTC (permalink / raw) To: dri-devel, yzq, boris.brezillon Hey, So I notice we have two unreviewed drivers outstanding, the atmel hlcdc and the rockchips one, I'd like to suggest they you guys review each others work, they should be quite close in terms of functionality and you might spot some problems in your own code from reading the other driver. I'm also hoping regular review will happen as well, but I think more cross-review is probably a good thing for new driver writers. Dave. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rockchip and atmel kms drivers 2014-09-17 1:18 rockchip and atmel kms drivers Dave Airlie @ 2014-09-17 5:41 ` Boris BREZILLON 2014-09-17 5:50 ` yaozq 2014-09-17 16:05 ` Rob Clark 0 siblings, 2 replies; 6+ messages in thread From: Boris BREZILLON @ 2014-09-17 5:41 UTC (permalink / raw) To: Dave Airlie; +Cc: yzq, Laurent Pinchart, dri-devel Hi Dave, On Wed, 17 Sep 2014 11:18:44 +1000 Dave Airlie <airlied@gmail.com> wrote: > Hey, > > So I notice we have two unreviewed drivers outstanding, the atmel > hlcdc and the rockchips one, I'd like to suggest they you guys review > each others work, they should be quite close in terms of functionality > and you might spot some problems in your own code from reading the > other driver. Sure, I'll review the rockchip driver. > > I'm also hoping regular review will happen as well, but I think more > cross-review is probably a good thing for new driver writers. One more point, as stated in my cover letter, the HLCDC driver depends on 2 other series ([1] and [2]), which I proposed after discussing it with other KMS developers (Rob, Laurent and Thierry). Could you take a look at these ones ? Best Regards, Boris [1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html [2]http://www.spinics.net/lists/kernel/msg1791681.html -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rockchip and atmel kms drivers 2014-09-17 5:41 ` Boris BREZILLON @ 2014-09-17 5:50 ` yaozq 2014-09-17 18:00 ` Boris BREZILLON 2014-09-17 16:05 ` Rob Clark 1 sibling, 1 reply; 6+ messages in thread From: yaozq @ 2014-09-17 5:50 UTC (permalink / raw) To: Boris BREZILLON, Dave Airlie; +Cc: Laurent Pinchart, dri-devel Hi Boris & Dave, I will update the rockchip drm driver soon, we have many change about it. thanks. On 2014年09月17日 13:41, Boris BREZILLON wrote: > Hi Dave, > > On Wed, 17 Sep 2014 11:18:44 +1000 > Dave Airlie <airlied@gmail.com> wrote: > >> Hey, >> >> So I notice we have two unreviewed drivers outstanding, the atmel >> hlcdc and the rockchips one, I'd like to suggest they you guys review >> each others work, they should be quite close in terms of functionality >> and you might spot some problems in your own code from reading the >> other driver. > Sure, I'll review the rockchip driver. > >> I'm also hoping regular review will happen as well, but I think more >> cross-review is probably a good thing for new driver writers. > One more point, as stated in my cover letter, the HLCDC driver depends > on 2 other series ([1] and [2]), which I proposed after discussing it > with other KMS developers (Rob, Laurent and Thierry). > > Could you take a look at these ones ? > > Best Regards, > > Boris > > [1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html > [2]http://www.spinics.net/lists/kernel/msg1791681.html > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rockchip and atmel kms drivers 2014-09-17 5:50 ` yaozq @ 2014-09-17 18:00 ` Boris BREZILLON 2014-09-18 9:55 ` yaozq 0 siblings, 1 reply; 6+ messages in thread From: Boris BREZILLON @ 2014-09-17 18:00 UTC (permalink / raw) To: yaozq; +Cc: Laurent Pinchart, dri-devel Hi Yaozq, On Wed, 17 Sep 2014 13:50:26 +0800 yaozq <yzq@rock-chips.com> wrote: > Hi Boris & Dave, > I will update the rockchip drm driver soon, we have many change about it. I'll wait for the new version then, just keep me in the loop when you send it. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rockchip and atmel kms drivers 2014-09-17 18:00 ` Boris BREZILLON @ 2014-09-18 9:55 ` yaozq 0 siblings, 0 replies; 6+ messages in thread From: yaozq @ 2014-09-18 9:55 UTC (permalink / raw) To: Boris BREZILLON; +Cc: Laurent Pinchart, dri-devel Hi Boris, I have updated new version drm driver, you can review it. Thanks. On 2014年09月18日 02:00, Boris BREZILLON wrote: > Hi Yaozq, > > On Wed, 17 Sep 2014 13:50:26 +0800 > yaozq <yzq@rock-chips.com> wrote: > >> Hi Boris & Dave, >> I will update the rockchip drm driver soon, we have many change about it. > I'll wait for the new version then, just keep me in the loop when you > send it. > > Thanks, > > Boris > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rockchip and atmel kms drivers 2014-09-17 5:41 ` Boris BREZILLON 2014-09-17 5:50 ` yaozq @ 2014-09-17 16:05 ` Rob Clark 1 sibling, 0 replies; 6+ messages in thread From: Rob Clark @ 2014-09-17 16:05 UTC (permalink / raw) To: Boris BREZILLON; +Cc: yzq, Laurent Pinchart, dri-devel On Wed, Sep 17, 2014 at 1:41 AM, Boris BREZILLON <boris.brezillon@free-electrons.com> wrote: > Hi Dave, > > On Wed, 17 Sep 2014 11:18:44 +1000 > Dave Airlie <airlied@gmail.com> wrote: > >> Hey, >> >> So I notice we have two unreviewed drivers outstanding, the atmel >> hlcdc and the rockchips one, I'd like to suggest they you guys review >> each others work, they should be quite close in terms of functionality >> and you might spot some problems in your own code from reading the >> other driver. > > Sure, I'll review the rockchip driver. > >> >> I'm also hoping regular review will happen as well, but I think more >> cross-review is probably a good thing for new driver writers. > > One more point, as stated in my cover letter, the HLCDC driver depends > on 2 other series ([1] and [2]), which I proposed after discussing it > with other KMS developers (Rob, Laurent and Thierry). oh, I didn't notice that the flip-work patches hadn't landed yet. Dave, [1] ("drm: rework flip-work framework") series has my r-b BR, -R > Could you take a look at these ones ? > > Best Regards, > > Boris > > [1]http://lkml.iu.edu/hypermail/linux/kernel/1407.1/04171.html > [2]http://www.spinics.net/lists/kernel/msg1791681.html > > -- > Boris Brezillon, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-18 9:56 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-17 1:18 rockchip and atmel kms drivers Dave Airlie 2014-09-17 5:41 ` Boris BREZILLON 2014-09-17 5:50 ` yaozq 2014-09-17 18:00 ` Boris BREZILLON 2014-09-18 9:55 ` yaozq 2014-09-17 16:05 ` Rob Clark
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox