dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: YoungJun Cho <yj44.cho@samsung.com>
Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org,
	a.hajda@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH 4/7] drm/exynos: fimd: move handle vblank position in TE handler
Date: Fri, 14 Nov 2014 10:20:07 +0900	[thread overview]
Message-ID: <546558C7.9020307@samsung.com> (raw)
In-Reply-To: <1412144353-13114-5-git-send-email-yj44.cho@samsung.com>

On 2014년 10월 01일 15:19, YoungJun Cho wrote:
> For providing VBLANK information, drm_handle_vblank() should
> be called properly, but it is blocked by wait_vsync_event
> condition which is set by manager_ops->wait_for_vblank().
> So moves it out from wait_vsync_event routine.

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 05c2a97a..f062335 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -983,10 +983,10 @@ static void fimd_te_handler(struct exynos_drm_manager *mgr)
>  	if (atomic_read(&ctx->wait_vsync_event)) {
>  		atomic_set(&ctx->wait_vsync_event, 0);
>  		wake_up(&ctx->wait_vsync_queue);
> -
> -		if (!atomic_read(&ctx->triggering))
> -			drm_handle_vblank(ctx->drm_dev, ctx->pipe);
>  	}
> +
> +	if (!atomic_read(&ctx->triggering))
> +		drm_handle_vblank(ctx->drm_dev, ctx->pipe);
>  }
>  
>  static struct exynos_drm_manager_ops fimd_manager_ops = {
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-11-14  1:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01  6:19 [PATCH 0/7] drm/exynos: modify LCD I80 interface display YoungJun Cho
2014-10-01  6:19 ` [PATCH 1/7] drm/exynos: fimd: remove unnecessary waiting vblank routine YoungJun Cho
2014-11-13  9:00   ` Inki Dae
2014-10-01  6:19 ` [PATCH 2/7] drm/exynos: fimd: add fimd_channel_win() to clean up code YoungJun Cho
2014-11-13  9:05   ` Inki Dae
2014-10-01  6:19 ` [PATCH 3/7] drm/exynos: fimd: modify vclk calculation for I80 i/f YoungJun Cho
2014-11-13  9:12   ` Inki Dae
2014-11-13  9:54     ` YoungJun Cho
2014-11-14  1:25       ` Inki Dae
2014-10-01  6:19 ` [PATCH 4/7] drm/exynos: fimd: move handle vblank position in TE handler YoungJun Cho
2014-11-14  1:20   ` Inki Dae [this message]
2014-10-01  6:19 ` [PATCH 5/7] drm/exynos: fimd: modify I80 i/f interrupt relevant routine YoungJun Cho
2014-11-14  1:36   ` Inki Dae
2014-11-16  0:53     ` YoungJun Cho
2014-10-01  6:19 ` [PATCH 6/7] drm/exynos: dsi: move TE irq handler registration position YoungJun Cho
2014-11-14  1:49   ` Inki Dae
2014-11-14  2:08     ` YoungJun Cho
2014-10-01  6:19 ` [PATCH 7/7] drm/exynos: dsi: move DSIM_STATE_ENABLED set position YoungJun Cho
2014-11-14  1:53   ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546558C7.9020307@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kyungmin.park@samsung.com \
    --cc=sw0312.kim@samsung.com \
    --cc=yj44.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox