[PATCH] drm: atmel-hlcdc: Add dependency on ARM

[PATCH] drm: atmel-hlcdc: Add dependency on ARM

[Boris Brezillon]

The atmel-hlcdc driver selects DRM_GEM_CMA_HELPER which makes use of
symbols only available when HAVE_DMA_ATTRS is selected.
Add a dependency on the ARM architecture which select this option.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
index 1a08562..99b4f06 100644
--- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
+++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
@@ -1,6 +1,6 @@
 config DRM_ATMEL_HLCDC
 	tristate "DRM Support for ATMEL HLCDC Display Controller"
-	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC
+	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: atmel-hlcdc: Add dependency on ARM

[Guenter Roeck]

On 01/23/2015 12:03 PM, Boris Brezillon wrote:
> The atmel-hlcdc driver selects DRM_GEM_CMA_HELPER which makes use of
> symbols only available when HAVE_DMA_ATTRS is selected.
> Add a dependency on the ARM architecture which select this option.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>   drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> index 1a08562..99b4f06 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
> +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> @@ -1,6 +1,6 @@
>   config DRM_ATMEL_HLCDC
>   	tristate "DRM Support for ATMEL HLCDC Display Controller"
> -	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC
> +	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM

&& HAVE_DMA_ATTRS

might have been a bit less restrictive. Are you sure this controller
is never used on any other architecture but arm, not even arm64 ?

Anyway, the xtensa:allmodconfig build is passing again with this patch
applied, so

Tested-by: Guenter Roeck <linux@roeck-us.net>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: atmel-hlcdc: Add dependency on ARM

[Boris Brezillon]

Hi Guenter,

On Fri, 23 Jan 2015 12:44:10 -0800
Guenter Roeck <linux@roeck-us.net> wrote:

> On 01/23/2015 12:03 PM, Boris Brezillon wrote:
> > The atmel-hlcdc driver selects DRM_GEM_CMA_HELPER which makes use of
> > symbols only available when HAVE_DMA_ATTRS is selected.
> > Add a dependency on the ARM architecture which select this option.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> >   drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > index 1a08562..99b4f06 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > @@ -1,6 +1,6 @@
> >   config DRM_ATMEL_HLCDC
> >   	tristate "DRM Support for ATMEL HLCDC Display Controller"
> > -	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC
> > +	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
> 
> && HAVE_DMA_ATTRS
> 
> might have been a bit less restrictive.

Actually I greped HAVE_DMA_ATTRS in the kernel source tree and
apparently nobody directly depends on it, they all depend on one or
several architectures instead.

> Are you sure this controller
> is never used on any other architecture but arm, not even arm64 ?

Not that I know of, but maybe Nicolas can give some hints about the
upcoming Atmel ARM64 processors (or the long awaited Atmel AVR 64 bits
processor :-)).

More seriously, if Atmel ever decide to reuse this IP on a different
architecture, I think we'll add an '&& (ARM || XXX)' condition to the
depends on line.
> 
> Anyway, the xtensa:allmodconfig build is passing again with this patch
> applied, so
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 

Thanks for reporting the bug and testing the fix.

Best Regards,

Boris



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: atmel-hlcdc: Add dependency on ARM

[Nicolas Ferre]

Le 24/01/2015 18:15, Boris Brezillon a écrit :
> Hi Guenter,
> 
> On Fri, 23 Jan 2015 12:44:10 -0800
> Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> On 01/23/2015 12:03 PM, Boris Brezillon wrote:
>>> The atmel-hlcdc driver selects DRM_GEM_CMA_HELPER which makes use of
>>> symbols only available when HAVE_DMA_ATTRS is selected.
>>> Add a dependency on the ARM architecture which select this option.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> ---
>>>   drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
>>> index 1a08562..99b4f06 100644
>>> --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
>>> +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
>>> @@ -1,6 +1,6 @@
>>>   config DRM_ATMEL_HLCDC
>>>   	tristate "DRM Support for ATMEL HLCDC Display Controller"
>>> -	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC
>>> +	depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
>>
>> && HAVE_DMA_ATTRS
>>
>> might have been a bit less restrictive.
> 
> Actually I greped HAVE_DMA_ATTRS in the kernel source tree and
> apparently nobody directly depends on it, they all depend on one or
> several architectures instead.
> 
>> Are you sure this controller
>> is never used on any other architecture but arm, not even arm64 ?
> 
> Not that I know of, but maybe Nicolas can give some hints about the
> upcoming Atmel ARM64 processors (or the long awaited Atmel AVR 64 bits
> processor :-)).
> 
> More seriously, if Atmel ever decide to reuse this IP on a different
> architecture, I think we'll add an '&& (ARM || XXX)' condition to the
> depends on line.

Yes, it's not planned in the near future. So we can keep the "ARM"
restriction for now I think.

Bye,

>> Anyway, the xtensa:allmodconfig build is passing again with this patch
>> applied, so
>>
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>
> 
> Thanks for reporting the bug and testing the fix.
> 
> Best Regards,
> 
> Boris
> 
> 
> 


-- 
Nicolas Ferre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel