From: Jochen Rollwagen <joro-2013@t-online.de>
To: dri-devel@lists.freedesktop.org
Subject: Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture
Date: Sun, 15 Feb 2015 19:27:48 +0100 [thread overview]
Message-ID: <54E0E524.5070003@t-online.de> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]
Hi,
i found a bug in uninorth-agp.c, function uninorth_fetch_size.
the line
size <http://lxr.free-electrons.com/ident?i=size> =memparse <http://lxr.free-electrons.com/ident?i=memparse>(aperture <http://lxr.free-electrons.com/ident?i=aperture>, &aperture <http://lxr.free-electrons.com/ident?i=aperture>) >> 20;
always sets size to zero which makes the driver allocate the default size of 256 MB which is obviously too large for older uninorth revisions.
I split the line into memparse and shifting and inserted diagnostic messages, output with uninorth_agp.aperture = 32 as boot parameter:
Feb 15 19:12:44 mac-mini kernel: [ 2.568636] agpgart-uninorth 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32
Feb 15 19:12:44 mac-mini kernel: [ 2.568642] agpgart-uninorth 0000:00:0b.0: size after >> 20: 0
It would be nice if a patch could be produced so i can experiment with
different aperture sizes without having to rebuild the kernel every time :-)
Cheers
Jochen
[-- Attachment #1.2: Type: text/html, Size: 1324 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-02-15 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 18:27 Jochen Rollwagen [this message]
2015-02-16 2:51 ` Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E0E524.5070003@t-online.de \
--to=joro-2013@t-online.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox