From: "Michel Dänzer" <michel@daenzer.net>
To: Jochen Rollwagen <joro-2013@t-online.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture
Date: Mon, 16 Feb 2015 11:51:05 +0900 [thread overview]
Message-ID: <54E15B19.9050105@daenzer.net> (raw)
In-Reply-To: <54E0E524.5070003@t-online.de>
On 16.02.2015 03:27, Jochen Rollwagen wrote:
> Hi,
>
> i found a bug in uninorth-agp.c, function uninorth_fetch_size.
>
> the line
>
> size = memparse(aperture, &aperture) >> 20;
>
> always sets size to zero which makes the driver allocate the default
> size of 256 MB which is obviously too large for older uninorth
> revisions.
Sounds like the default should be lower for older UniNorth revisions.
Can you make a patch for that?
> I split the line into memparse and shifting and inserted diagnostic
> messages, output with uninorth_agp.aperture = 32 as boot parameter:
>
> Feb 15 19:12:44 mac-mini kernel: [ 2.568636] agpgart-uninorth
> 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32 Feb 15
> 19:12:44 mac-mini kernel: [ 2.568642] agpgart-uninorth
> 0000:00:0b.0: size after >> 20: 0
Following your memparse link to
http://lxr.free-electrons.com/source/lib/cmdline.c#L127 , you can see
that the memparse function supports suffices such as 'M' or 'm'; without
suffix, the size is interpreted as bytes.
So you need something like uninorth_agp.aperture=32m .
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-02-16 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 18:27 Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture Jochen Rollwagen
2015-02-16 2:51 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E15B19.9050105@daenzer.net \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=joro-2013@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox