dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jani Nikula <jani.nikula@intel.com>,
	dri-devel@lists.freedesktop.org, Dave Airlie <airlied@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 0/9] drm: constify all helper_private/func pointers
Date: Wed, 11 Mar 2015 11:16:41 +0100	[thread overview]
Message-ID: <55001609.90805@amd.com> (raw)
In-Reply-To: <cover.1426066579.git.jani.nikula@intel.com>

Sounds logical to me to do so. Patch #4 and #9 are Reviewed-by: 
Christian König <christian.koenig@amd.com>

Regards,
Christian.

On 11.03.2015 10:50, Jani Nikula wrote:
> Per driver and core constification with cocci, final patch
> manually. Inspired by Ville in [1].
>
> BR,
> Jani.
>
> [1] http://mid.gmane.org/1425990920-17379-1-git-send-email-ville.syrjala@linux.intel.com
>
>
> Jani Nikula (9):
>    drm/exynos: constify all struct drm_*_helper funcs pointers
>    drm/mgag200: constify all struct drm_*_helper funcs pointers
>    drm/gma500: constify all struct drm_*_helper funcs pointers
>    drm/radeon: constify all struct drm_*_helper funcs pointers
>    drm/atmel-hlcdc: constify all struct drm_*_helper funcs pointers
>    drm/nouveau: constify all struct drm_*_helper funcs pointers
>    drm/qxl: constify all struct drm_*_helper funcs pointers
>    drm/drm: constify all struct drm_*_helper funcs pointers
>    drm: make crtc/encoder/connector/plane helper_private a const pointer
>
>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c    |  4 ++--
>   drivers/gpu/drm/drm_crtc_helper.c               | 24 ++++++++++++------------
>   drivers/gpu/drm/drm_fb_helper.c                 |  8 ++++----
>   drivers/gpu/drm/drm_plane_helper.c              |  4 ++--
>   drivers/gpu/drm/drm_probe_helper.c              |  2 +-
>   drivers/gpu/drm/exynos/exynos_hdmi.c            |  2 +-
>   drivers/gpu/drm/gma500/cdv_intel_display.c      |  2 +-
>   drivers/gpu/drm/gma500/cdv_intel_hdmi.c         |  2 +-
>   drivers/gpu/drm/gma500/cdv_intel_lvds.c         |  2 +-
>   drivers/gpu/drm/gma500/gma_display.c            | 10 +++++-----
>   drivers/gpu/drm/gma500/mdfld_dsi_output.c       |  2 +-
>   drivers/gpu/drm/gma500/mdfld_intel_display.c    |  2 +-
>   drivers/gpu/drm/gma500/oaktrail_crtc.c          |  2 +-
>   drivers/gpu/drm/gma500/oaktrail_hdmi.c          |  2 +-
>   drivers/gpu/drm/gma500/psb_intel_display.c      |  2 +-
>   drivers/gpu/drm/gma500/psb_intel_lvds.c         |  2 +-
>   drivers/gpu/drm/mgag200/mgag200_mode.c          |  2 +-
>   drivers/gpu/drm/nouveau/dispnv04/crtc.c         |  4 ++--
>   drivers/gpu/drm/nouveau/dispnv04/dac.c          |  4 ++--
>   drivers/gpu/drm/nouveau/dispnv04/dfp.c          |  4 ++--
>   drivers/gpu/drm/nouveau/dispnv04/disp.c         |  6 +++---
>   drivers/gpu/drm/nouveau/dispnv04/tvnv04.c       |  4 ++--
>   drivers/gpu/drm/nouveau/dispnv04/tvnv17.c       |  4 ++--
>   drivers/gpu/drm/nouveau/nouveau_connector.c     |  4 ++--
>   drivers/gpu/drm/qxl/qxl_drv.c                   |  2 +-
>   drivers/gpu/drm/radeon/radeon_connectors.c      | 16 ++++++++--------
>   drivers/gpu/drm/radeon/radeon_legacy_encoders.c |  2 +-
>   include/drm/drm_crtc.h                          |  8 ++++----
>   include/drm/drm_crtc_helper.h                   |  6 +++---
>   include/drm/drm_plane_helper.h                  |  2 +-
>   30 files changed, 70 insertions(+), 70 deletions(-)
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2015-03-11 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  9:50 [PATCH 0/9] drm: constify all helper_private/func pointers Jani Nikula
2015-03-11  9:50 ` [PATCH 1/9] drm/exynos: constify all struct drm_*_helper funcs pointers Jani Nikula
2015-03-11  9:51 ` [PATCH 2/9] drm/mgag200: " Jani Nikula
2015-03-11 15:26   ` Ian Romanick
2015-03-11  9:51 ` [PATCH 3/9] drm/gma500: " Jani Nikula
2015-03-11 11:21   ` Patrik Jakobsson
2015-03-11  9:51 ` [PATCH 4/9] drm/radeon: " Jani Nikula
2015-03-11  9:51 ` [PATCH 5/9] drm/atmel-hlcdc: " Jani Nikula
2015-03-11  9:51 ` [PATCH 6/9] drm/nouveau: " Jani Nikula
2015-03-11  9:51 ` [PATCH 7/9] drm/qxl: " Jani Nikula
2015-03-11  9:51 ` [PATCH 8/9] drm/drm: " Jani Nikula
2015-04-07 15:03   ` Daniel Vetter
2015-03-11  9:51 ` [PATCH 9/9] drm: make crtc/encoder/connector/plane helper_private a const pointer Jani Nikula
2015-03-11 10:16 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55001609.90805@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).