From: Ian Romanick <idr@freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>,
dri-devel@lists.freedesktop.org, Dave Airlie <airlied@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 2/9] drm/mgag200: constify all struct drm_*_helper funcs pointers
Date: Wed, 11 Mar 2015 08:26:29 -0700 [thread overview]
Message-ID: <55005EA5.1020706@freedesktop.org> (raw)
In-Reply-To: <e13ba1ec1c99fe3bbc70e5648714a10ef93fa1c3.1426066579.git.jani.nikula@intel.com>
On 03/11/2015 02:51 AM, Jani Nikula wrote:
> They are not to be modified.
>
> Generated using the semantic patch:
>
> @@
> @@
> (
> const struct drm_crtc_helper_funcs *
> |
> - struct drm_crtc_helper_funcs *
> + const struct drm_crtc_helper_funcs *
> )
>
> @@
> @@
> (
> const struct drm_encoder_helper_funcs *
> |
> - struct drm_encoder_helper_funcs *
> + const struct drm_encoder_helper_funcs *
> )
>
> @@
> @@
> (
> const struct drm_connector_helper_funcs *
> |
> - struct drm_connector_helper_funcs *
> + const struct drm_connector_helper_funcs *
> )
>
> @@
> @@
> (
> const struct drm_plane_helper_funcs *
> |
> - struct drm_plane_helper_funcs *
> + const struct drm_plane_helper_funcs *
> )
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 9872ba9abf1a..6e84df9369a6 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1222,7 +1222,7 @@ static void mga_crtc_commit(struct drm_crtc *crtc)
> {
> struct drm_device *dev = crtc->dev;
> struct mga_device *mdev = dev->dev_private;
> - struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> + const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
Presumably cases like this one could be 'const struct
drm_crtc_helper_funcs *const' but meh.
This patch is
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
...who hasn't had a patch in the Matrox driver in almost a decade.
> u8 tmp;
>
> if (mdev->type == G200_WB)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-11 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:50 [PATCH 0/9] drm: constify all helper_private/func pointers Jani Nikula
2015-03-11 9:50 ` [PATCH 1/9] drm/exynos: constify all struct drm_*_helper funcs pointers Jani Nikula
2015-03-11 9:51 ` [PATCH 2/9] drm/mgag200: " Jani Nikula
2015-03-11 15:26 ` Ian Romanick [this message]
2015-03-11 9:51 ` [PATCH 3/9] drm/gma500: " Jani Nikula
2015-03-11 11:21 ` Patrik Jakobsson
2015-03-11 9:51 ` [PATCH 4/9] drm/radeon: " Jani Nikula
2015-03-11 9:51 ` [PATCH 5/9] drm/atmel-hlcdc: " Jani Nikula
2015-03-11 9:51 ` [PATCH 6/9] drm/nouveau: " Jani Nikula
2015-03-11 9:51 ` [PATCH 7/9] drm/qxl: " Jani Nikula
2015-03-11 9:51 ` [PATCH 8/9] drm/drm: " Jani Nikula
2015-04-07 15:03 ` Daniel Vetter
2015-03-11 9:51 ` [PATCH 9/9] drm: make crtc/encoder/connector/plane helper_private a const pointer Jani Nikula
2015-03-11 10:16 ` [PATCH 0/9] drm: constify all helper_private/func pointers Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55005EA5.1020706@freedesktop.org \
--to=idr@freedesktop.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox