From: Emil Velikov <emil.l.velikov@gmail.com>
To: Jan Vesely <jan.vesely@rutgers.edu>, dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH libdrm 2/4] drmSL: Split tests to a separate file
Date: Sun, 22 Mar 2015 15:18:30 +0000 [thread overview]
Message-ID: <550EDD46.2060901@gmail.com> (raw)
In-Reply-To: <1426889428-4847-2-git-send-email-jan.vesely@rutgers.edu>
On 20/03/15 22:10, Jan Vesely wrote:
Considering that a separate commit removes the test from xf86drmSL.c can
you add some information in here. "This moves the test from ...."
> Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> ---
> .gitignore | 1 +
> tests/Makefile.am | 3 +-
> tests/drmsltest.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 175 insertions(+), 1 deletion(-)
> create mode 100644 tests/drmsltest.c
>
> diff --git a/.gitignore b/.gitignore
> index 06cc928..9c6ecd7 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -75,6 +75,7 @@ via.kld
> tests/auth
> tests/dristat
> tests/drmstat
> +tests/drmsltest
Perhaps we can omit the trailing test -> tests/drmsl ?
> tests/getclient
> tests/getstats
> tests/getversion
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 10f54e3..ca0f3c7 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -59,7 +59,8 @@ TESTS = \
> getstats \
> setversion \
> updatedraw \
> - name_from_fd
> + name_from_fd \
> + drmsltest
>
Can we try to keep this alphabetically sorted ?
I haven't verified that the code movement, although it seems that you've
nuked the trailing whitespace :-)
With the above comments addressed:
Acked-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-22 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 22:10 [PATCH libdrm 1/4] drmSL: Fix neighbor printing Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 2/4] drmSL: Split tests to a separate file Jan Vesely
2015-03-22 15:18 ` Emil Velikov [this message]
2015-03-24 23:06 ` [PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c Jan Vesely
2015-03-26 14:49 ` Emil Velikov
2015-03-20 22:10 ` [PATCH libdrm 3/4] drmsltest: Check expected neighbours Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 4/4] drmSL: Remove test parts Jan Vesely
2015-03-22 15:22 ` Emil Velikov
2015-03-22 15:13 ` [PATCH libdrm 1/4] drmSL: Fix neighbor printing Emil Velikov
2015-03-24 23:16 ` [PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup Jan Vesely
2015-03-26 14:53 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550EDD46.2060901@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jan.vesely@rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox