From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Jan Vesely" <jan.vesely@rutgers.edu>,
dri-devel@lists.freedesktop.org,
"Matthew W. S. Bell" <matthew@bells23.org.uk>,
"Kristian Høgsberg" <krh@bitplanet.net>,
"Kristian Høgsberg" <hoegsberg@gmail.com>
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup
Date: Thu, 26 Mar 2015 14:53:50 +0000 [thread overview]
Message-ID: <55141D7E.7080606@gmail.com> (raw)
In-Reply-To: <1427239003-25438-1-git-send-email-jan.vesely@rutgers.edu>
On 24/03/15 23:16, Jan Vesely wrote:
> Commit e4a519635f75bde38aeb5b09f2ff4efbf73453e9:
> Tidy up compile warnings by cleaning up types.
>
> removed call to SLLocate which gutted the function of all functionality.
> This patch restores the original behavior, with an additional fix
> that zeros the update array in case SLLocate bails early.
>
> v2: zero the update array instead of checking the return value.
> SLLocate returns NULL both on failure and if the element is greater
> than everything in the list
> v3: Improve commit message
>
> Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> Acked-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> sorry for spamming, just realized it might be a good idea co CC the original
> author and committer.
>
> This was broken since 2.4.18 (2010). I guess it's safe to say that nobody
> uses it. What are the policies on removing parts of API?
>
Either nobody uses it or nobody which uses it cases enough to report/fix
it. Either way I think that people prefer to be cautious and do API
cleanups alongside a major bump of the library.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-03-26 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 22:10 [PATCH libdrm 1/4] drmSL: Fix neighbor printing Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 2/4] drmSL: Split tests to a separate file Jan Vesely
2015-03-22 15:18 ` Emil Velikov
2015-03-24 23:06 ` [PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c Jan Vesely
2015-03-26 14:49 ` Emil Velikov
2015-03-20 22:10 ` [PATCH libdrm 3/4] drmsltest: Check expected neighbours Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 4/4] drmSL: Remove test parts Jan Vesely
2015-03-22 15:22 ` Emil Velikov
2015-03-22 15:13 ` [PATCH libdrm 1/4] drmSL: Fix neighbor printing Emil Velikov
2015-03-24 23:16 ` [PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup Jan Vesely
2015-03-26 14:53 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55141D7E.7080606@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegsberg@gmail.com \
--cc=jan.vesely@rutgers.edu \
--cc=krh@bitplanet.net \
--cc=matthew@bells23.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox